(#11) Bump Dependencies #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forced upgrade to vite 6 - things broke - Vite 6 requires Node >=19, so I bumped to Node 22. - Vite 6 changed the scss API, so you must use loadPaths instead of includePaths. Closes #11
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the project dependencies to support Vite 6 and updates the Node version accordingly, addressing compatibility issues introduced by Vite 6. Key changes include switching the SCSS configuration from includePaths to loadPaths, updating the Node and npm engine versions in package.json, and modifying the .nvmrc to reflect the new Node LTS release.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vite.config.js | Updated SCSS API option (includePaths → loadPaths) and added __dirname logic for ESM compatibility; note an unused destructured import. |
| package.json | Updated Node and npm engine versions along with the Vite dependency bump. |
| .nvmrc | Updated to the new Node LTS release stream. |
| import path from 'path'; | ||
|
|
||
| import { fileURLToPath } from 'url'; | ||
| import { dirname, join } from 'path'; |
There was a problem hiding this comment.
The imported 'join' is not used in this file; consider removing it to keep the code clean and avoid confusion.
Suggested change
| import { dirname, join } from 'path'; | |
| import { dirname } from 'path'; |
jfrank-nih
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of includePaths.
Closes #11