(#4383) prototyping imageless card group #1798
Conversation
Viewing Information |
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
3 times, most recently
from
c48bfbc to
373a6a9
Compare
|
At 879 width and below, the cards start to have varying heights depending on how long the content is. |
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
from
373a6a9 to
9c60bc2
Compare
|
On mobile large 480 and down when it stacks, can we increase the spacing from 16px to 24px to be consistent with our feature card stacking? 
And on desktop the spacing between rows, increase from 16px to 32px. |
|
@dlescarbeau not for the first imageless card but for the other groups of imageless cards, these needs titles (which will optional later on). Thank you! |
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
from
9c60bc2 to
8070ecb
Compare
| } | ||
| } | ||
|
|
||
| .imageless-card-group { |
There was a problem hiding this comment.
There was a problem hiding this comment.
(My bad, I figured prototyping implied it wasn't getting merged or something to that effect and it could be kinda WIPish)
There was a problem hiding this comment.
just wanna make sure the copy pasta will be correct when the time comes
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
5 times, most recently
from
65ea50d to
893d581
Compare
|
@dlescarbeau spacing updates look great, thank you! |
|
Also looks better to me! |
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
5 times, most recently
from
6f3bbc1 to
e1f75ad
Compare
| } | ||
|
|
||
| .nci-imageless-card-group { | ||
| .nci-heading-h2 { |
There was a problem hiding this comment.
Will this only ever be a styled with nci-heading-h2? I don't particularly trust that. Ideally, we would do something like .nci-imageless-card-group .nci-imageless-card-group__heading here and extend the default h2 styling with the extra margins. That is closer to how USWDS would design the element.
| @forward "uswds-utilities"; | ||
| @forward "usa-layout-grid"; | ||
| @forward "usa-prose"; | ||
| @forward "nci-heading"; |
There was a problem hiding this comment.
remove this after adjusting the note from above.
|
@dlescarbeau can you please update the second to last example to be a 2 card row, with 5 cards, so there are 3 total rows, the first two rows have two cards each, and the last row has one card? |
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
5 times, most recently
from
107bdc7 to
0c0d396
Compare
andyvanavery31
left a comment
andyvanavery31
left a comment
There was a problem hiding this comment.
Approved by Product and Client.
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
from
0c0d396 to
8ede300
Compare
- digital platform ticket Closes #4383
dlescarbeau
force-pushed
the
ticket/4383-imageless-card-prototype
branch
from
8ede300 to
455f66f
Compare
|
@laurelthrash updated with |
Closes #4383
NO MERGE