Skip to content

(#1683) Align Icon Button with USWDS Implementation (On Hold) #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dlescarbeau wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

(#1683) Align Icon Button with USWDS Implementation (On Hold) #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/ncids-css/packages/usa-button/internal/_nci-icon.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,8 @@ $svg-size: units(3);

// Full Width Icon Button
.usa-button--nci-icon.usa-button--nci-full-width {
@include u-display('block');
.usa-icon {
@include u-position('absolute');
@include u-float('left');
}
> span {
@include u-display('inline-block');
width: calc(100% - 48px);
}
}
4 changes: 2 additions & 2 deletions testing/ncids-css-testing/stories/components/usa-button/content/button.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{% macro buttonLabel(text, svg, class) %}
{% if svg and 'right' in class %}
<span>{{ text }} </span>{{ svg }}
{{ text }}{{ svg }}
{% elseif svg %}
{{ svg }}<span>{{ text }} </span>
{{ svg }}{{ text }}
{% else %}
{{ text }}
{% endif %}
Expand Down
26 changes: 16 additions & 10 deletions ...cids-css-testing/stories/components/usa-button/usa-button.modifiers.icon-left.stories.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,53 +11,59 @@ export default {
const buttonStyles = [
{
title: 'Primary',
class: 'usa-button--nci-icon',
class: '',
iconSvg: iconSvg,
},
{
title: 'Secondary',
class: 'usa-button--secondary usa-button--nci-icon',
class: 'usa-button--secondary',
iconSvg: iconSvg,
},
{
title: 'Accent Cool',
class: 'usa-button--accent-cool usa-button--nci-icon',
class: 'usa-button--accent-cool',
iconSvg: iconSvg,
},
{
title: 'Accent Warm',
class: 'usa-button--accent-warm usa-button--nci-icon',
class: 'usa-button--accent-warm',
iconSvg: iconSvg,
},
{
title: 'Base',
class: 'usa-button--base usa-button--nci-icon',
class: 'usa-button--base',
iconSvg: iconSvg,
},
{
title: 'Outline',
class: 'usa-button--outline usa-button--nci-icon',
class: 'usa-button--outline',
iconSvg: iconSvg,
},
{
title: 'Outline Secondary',
class: 'usa-button--outline usa-button--secondary usa-button--nci-icon',
class: 'usa-button--outline usa-button--secondary',
iconSvg: iconSvg,
},
{
title: 'Outline Inverse',
class: 'usa-button--outline usa-button--inverse usa-button--nci-icon',
class: 'usa-button--outline usa-button--inverse',
iconSvg: iconSvg,
containerClass: 'bg-base-darkest padding-2'
},
{
title: 'Full Width',
class: 'usa-button--nci-icon usa-button--nci-full-width',
class: 'usa-button--nci-full-width',
iconSvg: iconSvg,
},
{
title: 'Unstyled',
class: 'usa-button--unstyled usa-button--nci-icon',
class: 'usa-button--unstyled',
iconSvg: iconSvg,
containerClass: 'ncisb-flex-gap',
},
{
title: 'Unstyled Full Width',
class: 'usa-button--unstyled usa-button--nci-full-width',
iconSvg: iconSvg,
containerClass: 'ncisb-flex-gap',
}
Expand Down