Skip to content

Conversation

@dlescarbeau
Copy link
Collaborator

@dlescarbeau dlescarbeau commented Nov 5, 2024

Pull Request Details

  • Updates combo box event to pass an Array rather than an HTMLCollection to analytics event

Closes #1657

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

github-actions bot commented Nov 5, 2024

@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch from 49f8fb7 to 645fbff Compare November 5, 2024 19:36
@dlescarbeau dlescarbeau marked this pull request as ready for review November 6, 2024 15:12
@bennettcc bennettcc requested review from a team November 13, 2024 15:38
@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch from ef2cdd3 to b498c3b Compare November 13, 2024 16:00
@bennettcc
Copy link

This PR needs to be tested on an ODE

@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch 2 times, most recently from b498c3b to 1421523 Compare January 9, 2025 15:39
* Custom event details for the `combo-box:unselected` event.
*/
export type ComboBoxUnselectedEventDetails = ComboBoxEventDetails & {
/** An [HTML collection of selected options](https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions) before a change was made. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update all the comment blocks everywhere to match as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch 2 times, most recently from 45be4a6 to 8e356aa Compare January 15, 2025 15:37
@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch from 8e356aa to 1c42cb4 Compare January 15, 2025 15:46
@olitharp-nci
Copy link
Contributor

just waiting on approval after test on ode before merge

@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch from 89321b6 to de5a0ee Compare January 17, 2025 15:49
@bennettcc
Copy link

Per standup 1/24 - this needs to be tested by analytics team (Joe) before it's merged in

@dlescarbeau dlescarbeau force-pushed the ticket/1657-combo-box-update-selected-array branch from de5a0ee to bc6fd69 Compare January 28, 2025 15:46
@olitharp-nci olitharp-nci merged commit c1ed6fb into develop Jan 28, 2025
3 checks passed
@olitharp-nci olitharp-nci deleted the ticket/1657-combo-box-update-selected-array branch January 28, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace combo box event details selectedOptions with array of selected options.

5 participants