-
Notifications
You must be signed in to change notification settings - Fork 5
(#1657) Updates combo box selected event details to be array #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1657) Updates combo box selected event details to be array #1896
Conversation
Viewing Information |
49f8fb7 to
645fbff
Compare
ef2cdd3 to
b498c3b
Compare
|
This PR needs to be tested on an ODE |
b498c3b to
1421523
Compare
| * Custom event details for the `combo-box:unselected` event. | ||
| */ | ||
| export type ComboBoxUnselectedEventDetails = ComboBoxEventDetails & { | ||
| /** An [HTML collection of selected options](https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions) before a change was made. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update all the comment blocks everywhere to match as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
45be4a6 to
8e356aa
Compare
8e356aa to
1c42cb4
Compare
|
just waiting on approval after test on ode before merge |
89321b6 to
de5a0ee
Compare
|
Per standup 1/24 - this needs to be tested by analytics team (Joe) before it's merged in |
de5a0ee to
bc6fd69
Compare
Pull Request Details
Closes #1657
Author PR Checklist
Items that the author of the PR is responsible for checking before submitted the PR.
General:
Accessibility:
Development:
Product Reviewer PR Checklist
Items the product team is responsible for reviewing.
General:
Accessibility:
Design Reviewer PR Checklist
Items the design team is responsible for reviewing.
General:
Developer Reviewer PR Checklist
Items the development team is responsible for reviewing.
General:
Accessibility: