Skip to content

Conversation

@dlescarbeau
Copy link
Collaborator

@dlescarbeau dlescarbeau commented Nov 18, 2024

  • removes aria label from anchor

  • adds alt text value to image

Closes #423

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

@dlescarbeau dlescarbeau force-pushed the ticket/423-replace-logo-label-with-alt-text branch from 50f9f4e to 0b92d07 Compare November 18, 2024 18:38
@andyvanavery31
Copy link

@dlescarbeau could you please update the alt-text in the actual Doc Site header (not the component page) to be "National Cancer Institute Design System Homepage"?

@dlescarbeau dlescarbeau force-pushed the ticket/423-replace-logo-label-with-alt-text branch 2 times, most recently from 91dca72 to 2ed41b5 Compare November 19, 2024 19:19
@andyvanavery31 andyvanavery31 requested a review from a team November 19, 2024 20:35
Copy link

@andyvanavery31 andyvanavery31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes Product review.

@bennettcc bennettcc requested a review from a team November 20, 2024 15:28
@dlescarbeau dlescarbeau force-pushed the ticket/423-replace-logo-label-with-alt-text branch from 2ed41b5 to b71256f Compare November 25, 2024 15:31
Copy link
Contributor

@olitharp-nci olitharp-nci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header should be using the twig but I'd like to avoid scope creep for this PR. We should make another ticket, but otherwise this looks good

@dlescarbeau dlescarbeau force-pushed the ticket/423-replace-logo-label-with-alt-text branch from b71256f to 1ac0d33 Compare November 26, 2024 19:17
@olitharp-nci olitharp-nci force-pushed the ticket/423-replace-logo-label-with-alt-text branch from 1ac0d33 to a9e4a86 Compare November 26, 2024 22:43
- removes aria label from anchor

- adds alt text value to image

Closes #423
@dlescarbeau dlescarbeau force-pushed the ticket/423-replace-logo-label-with-alt-text branch from a9e4a86 to b5f49c3 Compare December 4, 2024 21:06
@olitharp-nci olitharp-nci merged commit efc9dfb into develop Dec 4, 2024
3 checks passed
@olitharp-nci olitharp-nci deleted the ticket/423-replace-logo-label-with-alt-text branch December 4, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CR: NCIDS - Remove Aria-Label and Add Alt-Text in Logo Index Link in Header

4 participants