Skip to content

Conversation

@olitharp-nci
Copy link
Contributor

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

@olitharp-nci olitharp-nci force-pushed the ticket/1943-foundations-error-handling branch from b7f57c8 to c363215 Compare January 16, 2025 17:49
@olitharp-nci
Copy link
Contributor Author

Screenshot 2025-01-16 at 10 54 02 AM
Screenshot 2025-01-16 at 10 50 01 AM

@olitharp-nci olitharp-nci force-pushed the ticket/1943-foundations-error-handling branch from c363215 to 8a4dc6e Compare January 27, 2025 17:56
@olitharp-nci olitharp-nci marked this pull request as ready for review January 28, 2025 16:00
Copy link
Member

@bryanpizzillo bryanpizzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket was unclear, sorry. The ticket has been updated to be clearer. The CI/CD workflow should FAIL if a utility is missing.

I have tested this by creating a prototype/ branch and removing the border utility. The CI/CD passed building the doc site. https://github.com/NCIOCPL/ncids/actions/runs/13018388484/job/36313085104

@olitharp-nci olitharp-nci force-pushed the ticket/1943-foundations-error-handling branch from 8a4dc6e to 89472d6 Compare January 31, 2025 18:24
@olitharp-nci olitharp-nci force-pushed the ticket/1943-foundations-error-handling branch from 89472d6 to f2154b9 Compare January 31, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants