Skip to content

Conversation

@karlikpj
Copy link
Contributor

Closes #4631

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

@karlikpj karlikpj force-pushed the ticket/4631-html-pull-quote branch 6 times, most recently from dd36dda to b16c2c3 Compare March 21, 2025 14:40
@karlikpj karlikpj marked this pull request as ready for review March 21, 2025 17:02
@karlikpj karlikpj force-pushed the ticket/4631-html-pull-quote branch from b16c2c3 to b4a9422 Compare March 27, 2025 15:27
@karlikpj karlikpj force-pushed the ticket/4631-html-pull-quote branch 2 times, most recently from 0a6b716 to 74915ab Compare July 1, 2025 16:47
@blilianyu
Copy link
Contributor

blilianyu commented Jul 2, 2025

@karlikpj Can you make the following updates?

  • border-left should be 3px and not 2px
  • quote should have line-height 3
  • author should have line-height 4
  • padding left and right should be 20px (token 205)
  • top and bottom padding should be 12px (token 105)

cc: @monika-jaeger

@karlikpj karlikpj force-pushed the ticket/4631-html-pull-quote branch 2 times, most recently from 367a568 to 0842901 Compare July 2, 2025 13:52
@karlikpj karlikpj force-pushed the ticket/4631-html-pull-quote branch from 0842901 to 92b9afe Compare July 2, 2025 14:01
@blilianyu
Copy link
Contributor

Updates look great! Thanks @karlikpj!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants