Skip to content

(#2099) External Link Bug #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlikpj wants to merge 1 commit into from
Closed

(#2099) External Link Bug #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions patches/@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1678,10 +1678,10 @@ index 983d2ed46d758291a903957e79df24c9043260dd..40a1f924922b3dd40129c28e453e51ea
extended: (),
),
diff --git a/packages/uswds-core/src/styles/mixins/general/external-link.scss b/packages/uswds-core/src/styles/mixins/general/external-link.scss
index 98e4d08c8c81efa3f61fe042c6cb7ffaf26bd89c..965bcb9b51a9487421fb707afc7a9a37ae5149b4 100644
index 98e4d08c8c81efa3f61fe042c6cb7ffaf26bd89c..32c5aece8ab3dda86f716490780d5637742892f3 100644
--- a/packages/uswds-core/src/styles/mixins/general/external-link.scss
+++ b/packages/uswds-core/src/styles/mixins/general/external-link.scss
@@ -2,40 +2,146 @@
@@ -2,40 +2,144 @@
@use "./icon" as *;
@use "../../functions" as *;
@use "./screen-reader" as *;
Expand Down Expand Up @@ -1782,8 +1782,6 @@ index 98e4d08c8c81efa3f61fe042c6cb7ffaf26bd89c..965bcb9b51a9487421fb707afc7a9a37
+// $margin-between is the space between the icon and the text
+@mixin external-link-wrap-with-text($margin-between: units(1.5)) {
+ $icon-size-in-pixels: $theme-external-link-icon-size * 1px;
+ // Display Block to wrap Icon with Text
+ display: block !important;
+ // Padding / Margin to prevent icon wrapping without text
+ padding-right: calc($margin-between + $icon-size-in-pixels) !important;
+ &::after {
Expand Down
Loading