(#20, #19) Load from filesystem. #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairlearn
force-pushed
the
ticket/20-local-fs
branch
8 times, most recently
from
6c68a9a to
c10ae1a
Compare
- Run npm audit fix - Bump version to 3.0.0 - Node version is a breaking change. - Previous version was v2.0.1, but package.json wasn't updated. - Remove comments from configuration files. - Config package no longer tolerates them. - Correct repository urls and package name. Closes #19
blairlearn
force-pushed
the
ticket/20-local-fs
branch
from
c10ae1a to
b78b710
Compare
blairlearn
force-pushed
the
ticket/20-local-fs
branch
2 times, most recently
from
e054d2c to
cc5890f
Compare
- Resource retrieval location. - Mapping files for transformer. - Add data for integration tests. - Update workflow. - File paths in CI configuration. - Update actions to current version - actions/checkout - actions/setup-node - actions/upload-artifact - Make artifact names unique. - Limit concurrent workflow execution - Update dependencies
blairlearn
force-pushed
the
ticket/20-local-fs
branch
from
cc5890f to
f50eb48
Compare
bryanpizzillo
requested changes
Oct 28, 2024
Member
bryanpizzillo
left a comment
bryanpizzillo
left a comment
There was a problem hiding this comment.
We should not have a copy of r4r-content here. (The resources under integration-tests). This should be testable with the same 5 resources from unit tests.
|
@bryanpizzillo @blairlearn - should this stay open or get closed? |
Contributor
Author
|
It should stay open until there's a decision what to do with the loader overall. (Retire R4R altogether? Redo the loader in Python? Keep the JS version?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
Closes #20