refactor: simplify NDLA and Feide auth logic#949
Merged
Conversation
amatho
force-pushed
the
refactor/simplify-auth
branch
2 times, most recently
from
5b08905 to
6cb8030
Compare
jnatten
reviewed
May 11, 2026
jnatten
approved these changes
May 12, 2026
Contributor
jnatten
left a comment
jnatten
left a comment
There was a problem hiding this comment.
LGTM (men hadde likt om den andre pr'en fiksa swagger auth+bad request greiene)
amatho
force-pushed
the
refactor/simplify-auth
branch
from
6cb8030 to
4f15929
Compare
amatho
force-pushed
the
refactor/simplify-auth
branch
from
4f15929 to
9580be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flytter henholdsvis Feide og Auth0 auth-logikk til
FeideAuthogNdlaAuth, og sørger for at vi bruker så mye som mulig av Tapir sine metoder for å definere auth inputs. Gjør atTapirControllerblir en del lettere å lese, og vi får samlet alt av auth-logikk i ett sted