refactor: create a common hook for handling editable slate components#3417
Draft
Jonas-C wants to merge 23 commits into
Draft
refactor: create a common hook for handling editable slate components#3417Jonas-C wants to merge 23 commits into
Jonas-C wants to merge 23 commits into
Conversation
Jonas-C
force-pushed
the
refactor/unify-slate-edit-state-handling
branch
from
05e00f1 to
7ce5caf
Compare
Jonas-C
force-pushed
the
refactor/unify-slate-edit-state-handling
branch
from
b4fc037 to
d83e455
Compare
gunnarvelle
reviewed
May 13, 2026
Member
There was a problem hiding this comment.
Dobbeltklikk på matte funker ikkje her.
gunnarvelle
reviewed
May 13, 2026
| </DialogHeader> | ||
| <DialogBody> | ||
| <LinkForm linkData={linkData} onSave={handleSave} onRemove={handleRemove} /> | ||
| <LinkForm linkData={linkData} onSave={onSave} onRemove={handleRemove} /> |
Member
There was a problem hiding this comment.
Her burde vi heller hatt handeUnwrap
Suggested change
| <LinkForm linkData={linkData} onSave={onSave} onRemove={handleRemove} /> | |
| <LinkForm linkData={linkData} onSave={onSave} onRemove={handleUnwrap} /> |
gunnarvelle
reviewed
May 13, 2026
| addConcept={(data) => handleSave({ data: getConceptDataAttributes(data, locale) })} | ||
| locale={locale} | ||
| concept={concept} | ||
| handleRemove={handleRemove} |
Member
There was a problem hiding this comment.
Suggested change
| handleRemove={handleRemove} | |
| handleRemove={handleUnwrap} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vi fortsetter å ha en hel haug med fokus-feil i slate-komponentene våre. Mistenker at vi kan ha færre hvis vi reduserer mengden ulikheter mellom de ulike embedene våre.