Skip to content

fix: spacing resourcelist #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ingridleriksen merged 3 commits into from
May 11, 2026
Merged

fix: spacing resourcelist #2918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e8f8f
fix: spacing resourcelist
ingridleriksen May 8, 2026
58fd7f5
fix: update spacing and structure in ResourceList component
ingridleriksen May 11, 2026
4eb1bfe
fix: refactor ResourceList component layout and remove unused Control…
ingridleriksen May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 40 additions & 43 deletions src/containers/MyNdla/Folders/components/ResourceList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ const BatchSelectOptionsWrapper = styled("div", {
transitionDuration: "fast",
transitionProperty: "opacity",
transitionTimingFunction: "ease-in-out",
minHeight: "3xlarge",
opacity: "0",
},
variants: {
Expand Down Expand Up @@ -162,48 +161,46 @@ export const ResourceList = ({ selectedFolder, resources, labelledBy }: Props) =
<ResourceSortOption />
</ListOptionsWrapper>
</ListActionsWrapper>
<BatchSelectOptionsWrapper visible={!!selectedResources.length}>
{!!selectedResources.length && (
<>
<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.move")}</Button>
</DialogTrigger>
<DialogContent>
<MoveResourcesDialogContent
currentFolder={selectedFolder}
resources={selectedResources}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.copy")}</Button>
</DialogTrigger>
<DialogContent>
<CopyResourcesDialogContent
currentFolder={selectedFolder}
resources={selectedResources}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.remove")}</Button>
</DialogTrigger>
<DialogContent>
<DeleteResourcesDialogContent
selectedFolder={selectedFolder}
resourceIds={selectedResourceIds}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
</>
)}
</BatchSelectOptionsWrapper>
{!!selectedResources.length && (
<BatchSelectOptionsWrapper visible>
Copy link
Copy Markdown
Contributor

@Jonas-C Jonas-C May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvis denne alltid er visible kan vi fjerne stylingen og propen.

<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.move")}</Button>
</DialogTrigger>
<DialogContent>
<MoveResourcesDialogContent
currentFolder={selectedFolder}
resources={selectedResources}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.copy")}</Button>
</DialogTrigger>
<DialogContent>
<CopyResourcesDialogContent
currentFolder={selectedFolder}
resources={selectedResources}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
<DialogRoot>
<DialogTrigger asChild>
<Button variant="secondary">{t("myNdla.resource.remove")}</Button>
</DialogTrigger>
<DialogContent>
<DeleteResourcesDialogContent
selectedFolder={selectedFolder}
resourceIds={selectedResourceIds}
onSuccessfulMutation={onSuccessfulMutation}
/>
</DialogContent>
</DialogRoot>
</BatchSelectOptionsWrapper>
)}
<CheckboxGroup value={selectedResourceIds} onValueChange={setSelectedResourceIds}>
<BlockWrapper aria-labelledby={labelledBy}>
{sortedAndFilteredResources.map((resource) => (
Expand Down
Loading