-
Notifications
You must be signed in to change notification settings - Fork 18
Completed "Course Student List in Course Info Page" #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
c1ydehhx
wants to merge
29
commits into
master
Choose a base branch
from
course-student-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c0999b7
Refactor: Migrate course related JSON
c1ydehhx 540eca7
Fix: Loading semester list when year and semester not exists.
c1ydehhx 488dc96
Refactor: course_connector.dart
c1ydehhx 8fda432
Refactor: course_connector.dart
c1ydehhx 22a870b
Migrate: Remove redundant json
c1ydehhx 0d2b1c0
Rename: course_syllabus and course_semester
c1ydehhx f10d450
Migrate: Remove must.dart
c1ydehhx 27770d7
Chore: format
c1ydehhx a1471a1
Chore: fix the issues from analyzer
c1ydehhx c0d8d0a
Chore: format
c1ydehhx 4aa1390
Implement: Use EEquatableMixin to instead of operator overloading
c1ydehhx 65d8bc8
Implement: use final when the value won't modify
c1ydehhx 4ae3cde
Implement: use final when the value won't modify
c1ydehhx 7ca37d3
Implement: use final when the value won't modify
c1ydehhx 24d296a
Implement: use final when the value won't modify
c1ydehhx 530cea0
Chore: Change required key to nullable key
c1ydehhx 1eea804
Chore: Simply the unique process with Set data structure
c1ydehhx 29e7c9b
Chore: Simply the unique process with addAll function
c1ydehhx df623de
Chore: Simply getUnknownCourse when reuse complex method chains
c1ydehhx b4b19a3
Chore: Add comma after the final things in a series of long parameters
c1ydehhx 4dc5e46
Chore: Optimize huge function chain when Pre-build member
c1ydehhx 54e8d44
Chore: Run format
c1ydehhx dfcf849
Chore: Optimize the implementation by add a value-mapping constructor
c1ydehhx 8ee64bb
Chore: Run format
c1ydehhx f990968
Chore: Add origin constructor & passed analyze & format it
c1ydehhx a014bc5
Implement: Load the student from iplus
c1ydehhx a6df93e
Implement: Course Student List
c1ydehhx 71b7878
Chore: format
c1ydehhx 7462308
Chore: analyze
c1ydehhx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this capitalized correctly?