[ERSSUP-78090]-[]-[Make getAttachment always return something for a v…#1898
Closed
[ERSSUP-78090]-[]-[Make getAttachment always return something for a v…#1898
Conversation
Contributor
|
lgtm |
stevebux
force-pushed
the
feature/ERSSUP-78090
branch
from
6c24fcc to
8ebc76a
Compare
nhsd-angel-pastor
approved these changes
Nov 22, 2024
stevebux
force-pushed
the
feature/ERSSUP-78090
branch
from
8ebc76a to
5768004
Compare
| response = call_endpoint_url_with_pathParams( | ||
| actor, {"attachmentLogicalID": "f1bb2b1-30db-48f9-8906-8b703adca5fb"} | ||
| ) | ||
| asserts.assert_status_code(404, response.status_code) |
Contributor
There was a problem hiding this comment.
I've noticed that this 404 should be a 422. This is caused by a bug that I've fixed in #1922 - path to files STU3-SandboxErrorOutcome.json and R4-SandboxErrorOutcome.json aren't correct for most files under routes/
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stevebux
force-pushed
the
feature/ERSSUP-78090
branch
from
5768004 to
bcc0988
Compare
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… valid UUID]-[SB]
stevebux
force-pushed
the
feature/ERSSUP-78090
branch
from
bcc0988 to
1149674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…alid UUID]-[SB]
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.