Skip to content

Conversation

@alistair-white-horne-tng
Copy link
Contributor

A Notify API key needs to be added to update_notify_templates/.env before the script is executed.

Copy link
Contributor

@paulrobertlloyd paulrobertlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, and will massively simplify the process of keeping these up to date. A few suggestions:

  • Let’s add something to the README.md explaining how to use this script, much like @murugapl has done in #25.
  • Given we are likely to add future Python-based scripts, it might make sense to move this under /scripts (possibly /scripts/update_notify_templates.py). Perhaps something to think about when we add subsequent Python scripts.

@alistair-white-horne-tng
Copy link
Contributor Author

Given we are likely to add future Python-based scripts, it might make sense to move this under /scripts (possibly /scripts/update_notify_templates.py). Perhaps something to think about when we add subsequent Python scripts.

@paulrobertlloyd I agree, but I'd be tempted to do this as a separate PR, because it sticks its fingers into the export_to_docx and Lakshmi's dynamic_screenshots. Or I could make the change as part of this PR. What do you think?

@alistair-white-horne-tng
Copy link
Contributor Author

Let’s add something to the README.md explaining how to use this script, much like @murugapl has done in #25.

Good point. Done that now.

@paulrobertlloyd
Copy link
Contributor

Happy to leave moving organising scripts until we have more of them to organise 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants