-
Notifications
You must be signed in to change notification settings - Fork 7
A script to update the notify templates in the user guide #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
A script to update the notify templates in the user guide #30
Conversation
paulrobertlloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, and will massively simplify the process of keeping these up to date. A few suggestions:
- Let’s add something to the
README.mdexplaining how to use this script, much like @murugapl has done in #25. - Given we are likely to add future Python-based scripts, it might make sense to move this under
/scripts(possibly/scripts/update_notify_templates.py). Perhaps something to think about when we add subsequent Python scripts.
@paulrobertlloyd I agree, but I'd be tempted to do this as a separate PR, because it sticks its fingers into the |
|
Happy to leave moving organising scripts until we have more of them to organise 👍 |
458448a to
848f740
Compare
848f740 to
fc17615
Compare
7e94c93 to
f07cc42
Compare
f07cc42 to
2cdbcab
Compare
A Notify API key needs to be added to
update_notify_templates/.envbefore the script is executed.