Skip to content

Conversation

@pchoi-al
Copy link
Contributor

@pchoi-al pchoi-al commented Jan 21, 2026

Description

Updated download V2 test and removed the V1 test

Fixes # (issue)

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@jsed-nhs jsed-nhs force-pushed the APPT-1753/migrate-playwright-test-v2-reports branch from 011c3f2 to 230ec1f Compare January 22, 2026 12:36
@jsed-nhs jsed-nhs marked this pull request as draft January 22, 2026 12:59
@pchoi-al pchoi-al force-pushed the APPT-1753/migrate-playwright-test-v2-reports branch 2 times, most recently from 37cd094 to 1c0c7a5 Compare January 28, 2026 10:32
Copy link
Contributor

@jsed-nhs jsed-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these changes are good and passing, can delete the V1 test

@jsed-nhs jsed-nhs self-requested a review January 28, 2026 11:29
jsed-nhs
jsed-nhs previously approved these changes Jan 28, 2026
@pchoi-al pchoi-al marked this pull request as ready for review January 28, 2026 15:01
@jsed-nhs jsed-nhs self-requested a review January 28, 2026 15:38
@pchoi-al pchoi-al force-pushed the APPT-1753/migrate-playwright-test-v2-reports branch from 1c9eac6 to 55a38e1 Compare January 28, 2026 16:30
@sonarqubecloud
Copy link

@pchoi-al pchoi-al changed the title Appt 1753/migrate playwright test v2 reports APPT-1753 migrate playwright test v2 download reports Jan 28, 2026
@pchoi-al pchoi-al merged commit 3df96ce into main Jan 28, 2026
2 checks passed
@pchoi-al pchoi-al deleted the APPT-1753/migrate-playwright-test-v2-reports branch January 28, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants