Fix: [AEA-4332] - Upgrade eslint (#182)

## Summary - Routine Change ### Details - upgrade eslint --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
NHSDigital · Aug 13, 2024 · a339256 · a339256
1 parent 4b915df
commit a339256
Show file tree

Hide file tree

Showing 7 changed files with 274 additions and 285 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -23,8 +23,7 @@
         "mkhl.direnv",
         "github.vscode-github-actions",
         "Orta.vscode-jest",
-        "rvest.vs-code-prettier-eslint",
-        "esbenp.prettier-vscode",
+        "dbaeumer.vscode-eslint",
         "ms-azuretools.vscode-docker",
         "tamasfe.even-better-toml"
       ],
@@ -36,31 +35,9 @@
         "editor.formatOnType": false,
         "editor.formatOnSave": true,
         "editor.formatOnSaveMode": "file",
-        "vs-code-prettier-eslint.prettierLast": false,
-        "[javascript]": {
-          "editor.defaultFormatter": "rvest.vs-code-prettier-eslint"
-        },
-        "[typescript]": {
-          "editor.defaultFormatter": "rvest.vs-code-prettier-eslint"
-        },
-        "[json]": {
-          "editor.defaultFormatter": "esbenp.prettier-vscode"
-        },
-        "[jsonc]": {
-          "editor.defaultFormatter": "esbenp.prettier-vscode"
-        },
-        "[yaml]": {
-          "editor.defaultFormatter": "esbenp.prettier-vscode"
-        },
-        "[markdown]": {
-          "editor.defaultFormatter": "esbenp.prettier-vscode"
-        },
-        "[dockerfile]": {
-          "editor.defaultFormatter": "ms-azuretools.vscode-docker"
-        },
-        "[toml]": {
-          "editor.defaultFormatter": "tamasfe.even-better-toml"
-        },
+        "eslint.useFlatConfig": true,
+        "eslint.format.enable": true,
+        "editor.defaultFormatter": "dbaeumer.vscode-eslint",
         "files.associations": {
           ".releaserc": "json"
         },

diff --git a/.eslintrc b/.eslintrc
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,127 @@
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import tsPlugin from "@typescript-eslint/eslint-plugin";
+import eslintJsPlugin from "@eslint/js";
+import importNewlines from "eslint-plugin-import-newlines";
+
+const commonConfig = {
+  plugins: {
+    "@typescript-eslint": tsPlugin,
+    "import-newlines": importNewlines,
+  },
+  rules: {
+    ...tsPlugin.configs.recommended.rules,
+    "@typescript-eslint/array-type": [
+      "error",
+      {
+        default: "generic",
+      },
+    ],
+
+    "@typescript-eslint/consistent-type-assertions": [
+      "error",
+      {
+        assertionStyle: "as",
+        objectLiteralTypeAssertions: "never",
+      },
+    ],
+
+    "block-spacing": "error",
+    "brace-style": ["error", "1tbs"],
+    "comma-dangle": ["error", "never"],
+
+    "comma-spacing": [
+      "error",
+      {
+        before: false,
+        after: true,
+      },
+    ],
+
+    "dot-location": ["error", "property"],
+    "eol-last": ["error", "always"],
+    eqeqeq: "error",
+    "func-call-spacing": "error",
+
+    "func-style": [
+      "error",
+      "declaration",
+      {
+        allowArrowFunctions: true,
+      },
+    ],
+
+    "import-newlines/enforce": [
+      "error",
+      {
+        items: 3,
+        "max-len": 120,
+        semi: false,
+      },
+    ],
+
+    indent: [
+      "error",
+      2,
+      {
+        SwitchCase: 1,
+      },
+    ],
+
+    "max-len": ["error", 120],
+    "no-multi-spaces": "error",
+
+    "no-multiple-empty-lines": [
+      "error",
+      {
+        max: 1,
+      },
+    ],
+
+    "no-trailing-spaces": "error",
+    "object-curly-spacing": ["error", "never"],
+
+    quotes: [
+      "error",
+      "double",
+      {
+        allowTemplateLiterals: true,
+        avoidEscape: true,
+      },
+    ],
+
+    semi: ["error", "never"],
+  },
+};
+
+export default [
+  {
+    ignores: ["**/lib/*", "**/coverage/*"],
+  },
+  {
+    rules: eslintJsPlugin.configs.recommended.rules,
+  },
+  {
+    files: ["**/*.ts"],
+
+    languageOptions: {
+      parser: tsParser,
+      globals: {
+        ...globals.node,
+      },
+    },
+    ...commonConfig,
+  },
+  {
+    files: ["**/tests/**/*.ts"],
+
+    languageOptions: {
+      parser: tsParser,
+      globals: {
+        ...globals.jest,
+        ...globals.node,
+      },
+    },
+    ...commonConfig,
+  },
+];