generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Replace #105, with non fork #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RossBugginsNHS
wants to merge
47
commits into
main
Choose a base branch
from
rossbugginsnhs/2025-11-17/post-schema-merge-changes-001
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 41 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
f7c72eb
updates.
RossBugginsNHS 268e7df
remove disabled publish workflow.
RossBugginsNHS 1ee5722
test: add comprehensive schema handling tests for import_asyncapi.py
RossBugginsNHS b3964e6
fix: resolve 19 SonarCloud MAJOR severity issues in dependancies.sh
RossBugginsNHS 1d50f5e
ci: download Python coverage reports for SonarCloud analysis
RossBugginsNHS f69fc2e
Tests for other python.
RossBugginsNHS 54fbafd
fix: preserve directory structure in Python coverage artifact upload
RossBugginsNHS 5be0388
Python coverage from anywhere.
RossBugginsNHS 1ef90fc
Correct spellings, remove duplicate dependencies file.
RossBugginsNHS eaefc8d
skipping dynamic and sonar via env vars.
RossBugginsNHS 11aa83a
use not cancelled
RossBugginsNHS d1e6a8d
use not cancelled
RossBugginsNHS b92ad6c
skip scan deps
RossBugginsNHS 2bdfbcd
add in needs.
RossBugginsNHS 5d1d90d
quote true and falses.
RossBugginsNHS 61f1741
remove needs.
RossBugginsNHS 1a3ca79
invert check
RossBugginsNHS c2593be
invert check
RossBugginsNHS ee29b3f
trying vars.
RossBugginsNHS 67e978f
adding to metadata instead.
RossBugginsNHS 8db5c7c
checks without strings.
RossBugginsNHS f9e0186
all from initial metadata.
RossBugginsNHS 2be6dd5
all from initial metadata.
RossBugginsNHS bfc9d79
pass correctly.
RossBugginsNHS bc68a64
remove quotes.
RossBugginsNHS 7431acb
remove more quotes.
RossBugginsNHS 37c43e5
outputs appear to always be strings.
RossBugginsNHS 00ca80e
composite actions dont support any types apart from strings.
RossBugginsNHS 626242d
add warning when sonar check disabled.
RossBugginsNHS 26363fa
make publish docs a composite action
RossBugginsNHS 39d66a9
put watning on dep scan being skipped
RossBugginsNHS a2756c4
add shells.
RossBugginsNHS 9d0b640
add summary step warnings.
RossBugginsNHS 78255e9
add summary step warnings.
RossBugginsNHS f6f0c8e
add summary step warnings.
RossBugginsNHS 999c282
improve warning messages.
RossBugginsNHS 03a45f9
improve warning messages.
RossBugginsNHS e4b1219
try out test results.
RossBugginsNHS ebed2b3
adding python too.
RossBugginsNHS c5a2901
checks write for test reports.
RossBugginsNHS e6f3c09
set permissions
RossBugginsNHS b5ef489
security: fix GitHub Actions command injection vulnerabilities and se…
RossBugginsNHS 56186e8
fix: add checkout step for test-reporter and pin to commit SHA
RossBugginsNHS abeb4cd
Set url for sonar.
RossBugginsNHS 12942e1
Set bypass of docs.
RossBugginsNHS ee7c474
Correct check for make docs existing.
RossBugginsNHS d3dce52
add check on tests.sh not existing in docs from main unit test.
RossBugginsNHS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "image": "mcr.microsoft.com/devcontainers/base:ubuntu-24.04", | ||
| "name": "Ubuntu 24" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: "Build Docs" | ||
| description: "build jekyll docs" | ||
| inputs: | ||
| version: | ||
| description: "Version of the software, set by the CI/CD pipeline workflow" | ||
| required: true | ||
| type: string | ||
| is_version_prerelease: | ||
| description: "Is this a semantically versioned pre release, set by the CI/CD pipeline workflow" | ||
| required: true | ||
| type: string | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: "Checkout code" | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: "Get artifacts: jekyll docs" | ||
| uses: actions/download-artifact@v5 | ||
| with: | ||
| path: ./artifacts/jekyll-docs-${{ inputs.version }} | ||
| name: jekyll-docs-${{ inputs.version }} | ||
|
|
||
| - name: "Get artifacts: schema" | ||
| uses: actions/download-artifact@v5 | ||
| with: | ||
| path: ./artifacts/schemas-${{ inputs.version }} | ||
| name: schemas-${{ inputs.version }} | ||
|
|
||
| - name: Draft Release | ||
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| GH_REPO: ${{ github.repository }} | ||
| run: | | ||
| gh release create \ | ||
| "${{ inputs.version }}" \ | ||
| --draft \ | ||
| --latest \ | ||
| --title "${{ inputs.version }}" \ | ||
| --notes "Release of ${{ inputs.version }}" \ | ||
| ${{ inputs.is_version_prerelease == 'true' && '--prerelease' || '' }} | ||
|
|
||
| - name: "Upload jeykll docs release asset" | ||
|
||
| shell: bash | ||
| env: | ||
|
||
| GH_TOKEN: ${{ github.token }} | ||
|
||
| GH_REPO: ${{ github.repository }} | ||
| run: | | ||
| cp ./artifacts/jekyll-docs-${{ inputs.version }}/artifact.tar $RUNNER_TEMP/jekyll-docs-${{ inputs.version }}.tar | ||
| gh release upload \ | ||
| "${{ inputs.version }}" \ | ||
| $RUNNER_TEMP/jekyll-docs-${{ inputs.version }}.tar#jekyll-docs-${{ inputs.version }} | ||
|
|
||
|
||
| - name: "Upload schema release asset" | ||
| shell: bash | ||
|
||
| env: | ||
|
||
| GH_TOKEN: ${{ github.token }} | ||
| GH_REPO: ${{ github.repository }} | ||
| run: | | ||
| cp ./artifacts/schemas-${{ inputs.version }}/artifact.tar $RUNNER_TEMP/schemas-${{ inputs.version }}.tar | ||
| gh release upload \ | ||
| "${{ inputs.version }}" \ | ||
| $RUNNER_TEMP/schemas-${{ inputs.version }}.tar#schemas-${{ inputs.version }} | ||
|
|
||
|
|
||
| - name: Publish Release | ||
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| GH_REPO: ${{ github.repository }} | ||
| run: gh release edit "${{ inputs.version }}" --draft=false | ||
48 changes: 48 additions & 0 deletions
48
.github/actions/setup-dependencies-asdf-with-cache/action.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: 'Setup depenasdf with cache' | ||
| description: 'Restores asdf cache, installs dependencies, and saves cache' | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: "Restore asdf cache" | ||
| id: cache-asdf | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: | | ||
| ~/.asdf | ||
| key: ${{ runner.os }}-asdf-${{ hashFiles('**/.tool-versions') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-asdf- | ||
|
|
||
| - name: "Check cache status" | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ steps.cache-asdf.outputs.cache-hit }}" == "true" ]; then | ||
| echo "✅ Cache hit! asdf and tools restored from cache. 🚀🚀🚀" | ||
| else | ||
| echo "❌ Cache miss. asdf and tools will be installed from scratch. 🔨🔨🔨" | ||
| fi | ||
|
|
||
| - name: "Install dependencies" | ||
| shell: bash -l {0} | ||
| run: | | ||
| make dependencies | ||
|
|
||
| - name: "Save asdf cache" | ||
| id: save-asdf-cache | ||
| if: steps.cache-asdf.outputs.cache-hit != 'true' | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| path: | | ||
| ~/.asdf | ||
| key: ${{ steps.cache-asdf.outputs.cache-primary-key }} | ||
|
|
||
| - name: "Check cache save status" | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ steps.cache-asdf.outputs.cache-hit }}" == "true" ]; then | ||
| echo "ℹ️ Cache was restored from previous run - no save needed" | ||
| elif [ "${{ steps.save-asdf-cache.outcome }}" == "success" ]; then | ||
| echo "✅ Cache saved successfully for future runs! 💾" | ||
| else | ||
| echo "⚠️ Cache save was skipped or failed" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.