Skip to content

Conversation

@ScottFullerton-NHSE
Copy link
Contributor

@ScottFullerton-NHSE ScottFullerton-NHSE commented Jan 21, 2026

Description

  • Added listener to the event bus which connects to a new scanner queue which invokes a lambda to move the documentReference from the PII bucket to the new S3 bucket in the suppliers aws account for virus scanning.

Context

Required as part of the virus-scanning solution for digital letters.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Test Evidence:
For testing, I uploaded a dummy documentReference to the pii bucket, and then sent a test event to the event bus to trigger the sequence.
image
image
image
image

@ScottFullerton-NHSE ScottFullerton-NHSE requested review from a team as code owners January 21, 2026 13:35
@ScottFullerton-NHSE ScottFullerton-NHSE added the enhancement New feature or request label Jan 22, 2026
@Ian-Hodges Ian-Hodges self-assigned this Jan 22, 2026
Ian-Hodges
Ian-Hodges previously approved these changes Jan 26, 2026
simonlabarere
simonlabarere previously approved these changes Jan 29, 2026
Updating how unscanned_files_bucket is referenced due to it being a remote state bucket.

Co-authored-by: Aiden Vaines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants