-
Notifications
You must be signed in to change notification settings - Fork 3
CCM-13478: Improve Pipeline Times #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CCM-13478: Improve Pipeline Times #191
Conversation
|
This is a really nice improvement in build times! Looking at the build pipeline with these changes though, I wonder if we need to run the static analysis step after the unit tests have completed? I don't see a reason why we would need to, and if we can do it in parallel I think we could shave off another ~1m30s. |
| with: | ||
| filters: | | ||
| schemas: | ||
| - 'schemas/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schemas is a generated directory, so I think if this job has just checked out the code and not run any build steps it will never be present:
| - 'schemas/**' |
| - 'docs/**' | ||
| - '**.md' | ||
| schemas: | ||
| - 'schemas/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, the schemas directory doesn't actually exist in the source tree.
| - 'schemas/**' |
| filters: | | ||
| docs: | ||
| - 'docs/**' | ||
| - '**.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bit of a broad match? I think a change to any of our README.md files would match this, wouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about the README files, I'll narrow that down.
Description
Context
Speeds up build pipelines which will save developers time when deploying/testing changes.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.
Evidence of passing pipeline: https://github.com/NHSDigital/nhs-notify-digital-letters/actions/runs/21437075657