Skip to content

Conversation

@ScottFullerton-NHSE
Copy link
Contributor

@ScottFullerton-NHSE ScottFullerton-NHSE commented Jan 27, 2026

Description

  • Made the docs-build conditional.
  • Integration tests set to run in parallel.
  • npm dependency caching
  • python pip caching
  • Ruby bundling caching
  • Removed test-coverage step as it wasn't used/required.

Context

Speeds up build pipelines which will save developers time when deploying/testing changes.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Evidence of passing pipeline: https://github.com/NHSDigital/nhs-notify-digital-letters/actions/runs/21437075657

@ScottFullerton-NHSE ScottFullerton-NHSE requested review from a team as code owners January 27, 2026 09:46
@gareth-allan gareth-allan self-assigned this Jan 29, 2026
@lapenna-bjss lapenna-bjss self-assigned this Jan 29, 2026
@gareth-allan
Copy link
Contributor

This is a really nice improvement in build times! Looking at the build pipeline with these changes though, I wonder if we need to run the static analysis step after the unit tests have completed? I don't see a reason why we would need to, and if we can do it in parallel I think we could shave off another ~1m30s.

with:
filters: |
schemas:
- 'schemas/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemas is a generated directory, so I think if this job has just checked out the code and not run any build steps it will never be present:

Suggested change
- 'schemas/**'

- 'docs/**'
- '**.md'
schemas:
- 'schemas/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the schemas directory doesn't actually exist in the source tree.

Suggested change
- 'schemas/**'

filters: |
docs:
- 'docs/**'
- '**.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bit of a broad match? I think a change to any of our README.md files would match this, wouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about the README files, I'll narrow that down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants