Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Data Type Issues To Enable Pandas 3.x Compatibility
This PR fixes various issues relating to how data are accessed in Pandas DataFrames, changes to default datetime resolutions, and a previously unidentified metrics bug.
PR Checklist
CHANGELOG.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
N/A
Impacted areas of the software
wombat/core/library.pyformat_weather: Manually casts datetime data to "ns" resolution for updated Pandas compatibility.wombat/core/post_processor.pyMetrics._apply_inflation_rate: Converts all cost columns to float types for Pands 3.x incompatibility with implicit casting during mathematical operations.Metrics.vessel_crew_hours_at_sea: Replacesgroup_colswithfrequency.group_colsfortotal_hoursgrouping that was previously missed.wombat/windfarm/windfarm.pyWindfarm._create_graph_layout: Repalces.valueswith.to_numpy()for turbine, substation, and electrolyzer id creation.Additional supporting information
Python version: 3.13.11
WOMBAT version (
wombat.__version__): 0.13.2Test results, if applicable
Tests now pass with Pandas 2.x and 3.x