Bump to MSRV 1.85 and overhaul CI #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Important note: I just noticed that the existing CI runs tests for many unnecessary combinations, e.g. |
mozzieongit
requested changes
Dec 1, 2025
Contributor
Author
|
And now we get some actual codebase issues to fix. |
bal-e
force-pushed
the
msrv-1.85
branch
3 times, most recently
from
bb77a57 to
573d3c1
Compare
Contributor
Author
|
I'd like to merge this after #390, as the conflicts are easier to fix here than there. |
mozzieongit
approved these changes
Dec 10, 2025
Member
mozzieongit
left a comment
mozzieongit
left a comment
There was a problem hiding this comment.
Interesting that rustfmt's import ordering changed
This is much more thorough and omits unnecessary duplicate checks (e.g. of feature flag combinations). It also detects the right MSRV.
We're using MSRV 1.85 in 'domain' already, and it unlocks edition 2024 support.
That crate uses a strange versioning system, making it difficult to enforce minimum-versions. It turns out we don't need it anyway, as the traits we had annotated are never used in trait objects.
1.1.6 adds serde de support for 'Box<Utf8Path>'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using MSRV 1.85 in 'domain' already, and it unlocks edition 2024 support. I noticed the CI was hard-coding the MSRV, so I copied our existing CI workflow from 'domain' which is much more thorough.