Set up the initial implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the 'src/crypto/kmip.rs' file from the 'poc-kmip-crypto-impl' pull request on Domain: <NLnetLabs/domain#540>. The file has not been modified at all, to serve as a good base for reviewing changes. There are dozens of compilation failures that will be addressed in the following commits.
Some of the dependencies, such as 'bcder', could be replaced with simple manual implementations. Importantly, the 'openssl' dependency has not been resolved; it will be replaced with use of 'bcder'.
This replaces the dependency on OpenSSL.
'domain' uses 'SignError' for representing on-disk cryptography failures. This is not appropriate for KMIP, but currently we implement the same 'SignRaw' trait anyway. This means we can't stuff enough error information in the 'SignError' type. We should stop implementing 'SignRaw', use a custom error type, and provide an asynchronous API.
Also catches a logic bug in the parser.
Should resolve the minimum versions CI check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports KMIP-related changes from NLnetLabs/domain#540. It avoids making further changes to
domain, although some signing-related changes in that PR still need to be merged. It exposes the same API as in that PR, except that KMIP is no longer part ofdomain'sKeyPairenum; it needs to be imported and used more explicitly. This will require a minor change in downstream codebases (i.e. Cascade anddnst keyset) that rely on this code.