Introduce a new net::server module
#482
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It implements 'Hash' for the provided integer types.
Some DNSSEC types use single-byte prefixed data, for which I'd still like to make use of 'SizePrefixed' to avoid boilerplate.
This will be used for zonefile parsing.
'bumpalo' is useful for allocating unsized data types like record data. It is currently used in the 'new-zonefile' branch as a buffer space for records to be parsed into. 'clone_to_bump()' is necessary in order to deep-copy record data into a new bump allocator.
These are important for improving DST ergonomics; they make it much easier to copy around unsized types, which 'domain' now has many of.
'CanonicalName' introduces important operations for DNSSEC. It is only implemented by 'Name' (not 'RevName') because 'RevName' cannot implement it efficiently (users should prefer 'RecordData<&Name>').
This helps prevent users from accidentally forgetting to commit the components of the message they're building.
This also resolves some bugs in 'ParsedMessage' which would result in questions and records getting omitted from the message. These were caught due to new 'must_use' attributes in 'new-base'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for overhauling
net::serveron top ofnew_base. It aims to address some of the shortcomings we have encountered with the service layering design, while otherwise being a relatively faithful refactoring of the entire module.