Patches for nameshed prototype. #496
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig arguments, and make the apex optional as it isn't needed for a full zone. - Split generate_rrsigs() apex handling functionality out to generate_apex_rrsigs(). - Split generate_rrsigs() key logging functionality out to log_keys_in_use(). - Use log::log_enabled() now that PR #465 has been merged. - Add some initial generate_rrsigs() tests. - Fix missing unwrap()s after calling .insert() in RustDoc example code.
…ses Box<[u8]> internally).
- Add a full zone test of generate_rrsigs() with default config. - Change SigningKeyUsageStrategy to return Vec and have generate_rrsigs() sort and dedup the results of its fns so that DNSKEY RRs are generated in a deterministic order and that implementers don't have to create short lived HashSets. (even creating Vec isn't ideal...)
…end, otherwise inserts via a large iterator will sort per insert which is slow comparing to dedup and sort after extend (and will make use of the Sorter too).
… key usage strategies.
…y, remove them again.
This change implements `FreezeBuilder` for `TreeCompressor` and `HashCompressor`, allowing methods like `into_message()` to be used when building messages with these compressors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks used by the
demo-with-rotonda-basebranch of the NLnetLabs/nameshed repo.Builds on #484.
Includes #535.