Introduce StorageSystem. - #1383
Merged
Merged
Conversation
Koenvh1
reviewed
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an additional layer for the key value store that can keep global information. This is another step in preparation for introducing support for database storage which will have connection pools and such that are shared system-wide.
Since this storage system isn’t actually used yet, the PR for now is just a massive refactoring and does not introduce any functional changes.
This PR makes the
storage_uri(aliased asdata_dir) config option mandatory and drops both it being read from an environment variable or defaulting to./data. Because of this, this is a breaking change.