Reduce memory fragmentation with RRsets with many RRs in them #472
+212
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtoorop
changed the title
wtoorop
changed the title
found by clang static code analysis
Member
Author
|
@saj Do you think you can find the time to try out the devel/reduce-fragmentation-with-many-RR-RRsets branch? Thanks! |
|
@wtoorop oh sure it is the least I can do. :) Thank you! |
Member
Author
Excellent and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some zones, such as DNS-SD zones, have RRsets with many RRs in them. By minimizing the need to reallocate the list of RRs in an RRset, we will reduce memory fragmentation significantly for such zones. To this end, with this PR, RRs within an RRset, that are grouped together in a zone file, will be committed to the database in batches.