tls-supported-groups SvcParam support #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://datatracker.ietf.org/doc/draft-ietf-tls-key-share-prediction/01/ Also: - draft-ietf-ohai-svcb-config became RFC 9540 for the ohttp SvcParam - added tests for ohttp
wtoorop
commented
Nov 8, 2024
wcawijngaards
approved these changes
Nov 8, 2024
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
The review comment was already resolved. Thank you for the quick fix!
k0ekk0ek
reviewed
Nov 11, 2024
Contributor
|
@wtoorop, looks mostly good to me. Just the one remark. |
So SIMD cmpeq on mnemonics keeps working as intended
k0ekk0ek
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in https://datatracker.ietf.org/doc/draft-ietf-tls-key-share-prediction/01/
Also: