Additional rr types #246
Merged
Additional rr types #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not CDNSKEY which was a mistake
Which allows '0' to indicate no keying material. Also, empty DOA-DATA can be specified with a '-', but '0' is also accepted for backwards compatibility.
AMTRELAY and IPN are now also supported
Co-authored-by: Wouter Wijngaards <[email protected]>
wcawijngaards
approved these changes
Jan 23, 2025
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
It is really nice to have a more comprehensive support for RR types! The code looks fair, the complication of the parser makes it way into the new parsed field types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for EID, NIMLOC, SINK, TALINK, DSYNC, DOA, AMTRELAY and IPN RR types.