Skip to content

Modify ECMWF filename ending for future easy testing.#934

Open
XiaoxueWang-NCO wants to merge 1 commit intoNOAA-EMC:developfrom
XiaoxueWang-NCO:feature/ecmwf_testing
Open

Modify ECMWF filename ending for future easy testing.#934
XiaoxueWang-NCO wants to merge 1 commit intoNOAA-EMC:developfrom
XiaoxueWang-NCO:feature/ecmwf_testing

Conversation

@XiaoxueWang-NCO
Copy link
Copy Markdown

Note to developers: You must use this PR template!

Description of Changes

Modify ECMWF filename default ending 1 to $ECMWF_FILE_EXT for future easy testing (testing data always have different ending number other than 1).

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by?
    I'd like the change to put in before/on the date ECMWF implement 50r1 upgrade May 12th.
  • Do you have any planned upcoming annual leave/PTO?
  • Are there any changes needed in the times when the jobs are supposed to run/kick-off?
  • The code changes follow NCO's EE2 Standards.
  • [x ] Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • [x ] References the feature branch for HOMEevs are removed from the code.
  • [xx= ] J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • [x ] If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.
Run with ECMWF test data

@malloryprow
Copy link
Copy Markdown
Contributor

Are we able to test this if Dataflow removed the test data?

@malloryprow malloryprow added this to the EVS v2.1 milestone Mar 27, 2026
@malloryprow malloryprow added the enhancement New feature or request label Mar 27, 2026
@malloryprow malloryprow self-assigned this Mar 27, 2026
@XiaoxueWang-NCO
Copy link
Copy Markdown
Author

XiaoxueWang-NCO commented Mar 27, 2026 via email

'ecmwf',
'DCD{init?fmt=%m%d%H}00'
+'{init?fmt=%m%d%H}001'),
+'{init?fmt=%m%d%H}00'+f'{ECMWF_FILE_EXT}'),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malloryprow I have reviewed the code changes for my ush/subseasonal/subseasonal_prep_obs.py script and the changes make sense. I approve once at least one test is conducted with the new ECMWF data.

@malloryprow
Copy link
Copy Markdown
Contributor

I can do a test with the regular data, but I'd like to do a test with the test extension too to make sure it works. Can the test data be brought back?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of defining ${ECMWF_FILE_EXT:-1} on each line, can we define export ECMWF_FILE_EXT=${ECMWF_FILE_EXT:-1} outside the loop (maybe around line 86). And then on the lines we can just have ${ECMWF_FILE_EXT}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I should define ECMWF_FILE_EXT in the J-job script.

@XiaoxueWang-NCO
Copy link
Copy Markdown
Author

XiaoxueWang-NCO commented Mar 27, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants