Modify ECMWF filename ending for future easy testing.#934
Modify ECMWF filename ending for future easy testing.#934XiaoxueWang-NCO wants to merge 1 commit intoNOAA-EMC:developfrom
Conversation
|
Are we able to test this if Dataflow removed the test data? |
|
Yes, if no test data, the ECMWF_FILE_EXT is default to 1, the scripts
should work like current production. When testing new ECMWF data, I'll
define ECMWF_FILE_EXT at run.ver
…On Fri, Mar 27, 2026 at 11:29 AM Mallory Row ***@***.***> wrote:
*malloryprow* left a comment (NOAA-EMC/EVS#934)
<#934?email_source=notifications&email_token=ATVUBSILHMALHJSVVM5O2RD4S2M5NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGM2DEOBYGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4143428850>
Are we able to test this if Dataflow removed the test data?
—
Reply to this email directly, view it on GitHub
<#934?email_source=notifications&email_token=ATVUBSILHMALHJSVVM5O2RD4S2M5NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGM2DEOBYGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4143428850>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATVUBSOMDWUEF3MDNWQ6O4L4S2M5NAVCNFSM6AAAAACXCENVBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBTGQZDQOBVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| 'ecmwf', | ||
| 'DCD{init?fmt=%m%d%H}00' | ||
| +'{init?fmt=%m%d%H}001'), | ||
| +'{init?fmt=%m%d%H}00'+f'{ECMWF_FILE_EXT}'), |
There was a problem hiding this comment.
@malloryprow I have reviewed the code changes for my ush/subseasonal/subseasonal_prep_obs.py script and the changes make sense. I approve once at least one test is conducted with the new ECMWF data.
|
I can do a test with the regular data, but I'd like to do a test with the test extension too to make sure it works. Can the test data be brought back? |
There was a problem hiding this comment.
Instead of defining ${ECMWF_FILE_EXT:-1} on each line, can we define export ECMWF_FILE_EXT=${ECMWF_FILE_EXT:-1} outside the loop (maybe around line 86). And then on the lines we can just have ${ECMWF_FILE_EXT}
There was a problem hiding this comment.
That's right. I should define ECMWF_FILE_EXT in the J-job script.
|
I'll ask Dataflow to pull another cycle next week.
…On Fri, Mar 27, 2026 at 11:46 AM Mallory Row ***@***.***> wrote:
*malloryprow* left a comment (NOAA-EMC/EVS#934)
<#934?email_source=notifications&email_token=ATVUBSI3XFHEGCFL6SM2YG34S2O4XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGM2TGMRWHEZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4143532692>
I can do a test with the regular data, but I'd like to do a test with the
test extension too to make sure it works. Can the test data be brought back?
—
Reply to this email directly, view it on GitHub
<#934?email_source=notifications&email_token=ATVUBSI3XFHEGCFL6SM2YG34S2O4XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGM2TGMRWHEZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4143532692>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATVUBSJOUAYNAKALGGKMZKL4S2O4XAVCNFSM6AAAAACXCENVBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBTGUZTENRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Note to developers: You must use this PR template!
Description of Changes
Developer Questions and Checklist
I'd like the change to put in before/on the date ECMWF implement 50r1 upgrade May 12th.
${USER}where necessary throughout the code.HOMEevsare removed from the code.dev/drivers/scriptsordev/modulefileshave been made in the correspondingecf/scriptsandecf/defs/evs-nco.def?Testing Instructions