Skip to content

Bugfix/subseasonal name error#937

Open
ShannonShields-NOAA wants to merge 3 commits intoNOAA-EMC:developfrom
ShannonShields-NOAA:bugfix/subseasonal_name_error
Open

Bugfix/subseasonal name error#937
ShannonShields-NOAA wants to merge 3 commits intoNOAA-EMC:developfrom
ShannonShields-NOAA:bugfix/subseasonal_name_error

Conversation

@ShannonShields-NOAA
Copy link
Copy Markdown
Contributor

@ShannonShields-NOAA ShannonShields-NOAA commented Mar 27, 2026

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.
While testing new ECMWF data, discovered minor bug with NameError associated with print statements in subseasonal_stats_grid2grid_create_days6_10_anomaly.py, subseasonal_stats_grid2grid_create_weekly_anomaly.py, and subseasonal_stats_grid2grid_create_weeks3_4_anomaly.py:
File "/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/global/test_new_ecmwf/EVS/ush/subseasonal/subseasonal_stats_grid2grid_create_days6_10_anomaly.py", line 172, in
print("\nWARNING: "+input_file+" does not exist")
NameError: name 'input_file' is not defined.

Minor fixes were applied to subseasonal_stats_grid2grid_create_days6_10_anomaly.py, subseasonal_stats_grid2grid_create_weekly_anomaly.py, and subseasonal_stats_grid2grid_create_weeks3_4_anomaly.py to successfully generate WARNING print statement when data is missing:
WARNING: /lfs/h2/emc/stmp/shannon.shields/evs_test/prod/tmp/jevs_stats_subseasonal_cfs_grid2grid.256189101.cbqs01/grid2grid_stats/METplus_output/job_work_dir/reformat_data/job65/atmos.20260325/cfs/grid2grid/grid_stat_pres_lvls_GeoHeightAnom_4440000L_20260315_120000V_pairs.nc does not exist

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by? No
  • Do you have any planned upcoming annual leave/PTO? No
  • Are there any changes needed in the times when the jobs are supposed to run/kick-off?
    No
  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.
Create testing directory on WCOSS2 (prtest937)
git clone https://github.com/ShannonShields-NOAA/EVS.git
cd EVS/
git checkout bugfix/subseasonal_name_error
git branch (to confirm you are on right branch)
Link fix directory (ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix fix)
Go to dev/drivers/scripts/stats/subseasonal/
In jevs_stats_subseasonal_cfs_grid2grid.sh and jevs_stats_subseasonal_gefs_grid2grid.sh, edit the following:
HOMEevs to your test directory path
export KEEPDATA=YES
Set COMOUT to where you want the stats files
Set COMIN=/lfs/h2/emc/vpppg/noscrub/mallory.row/verification/global/test_new_ecmwf/evs/v2.0/prep/subseasonal/
OR copy the data directories above to another path
NOTE: Make sure to cd atmos.20260316 and remove the following directories:
rm -r cfs
rm -r gefs
rm -r gfs
rm -r ghrsst_ospo
rm -r osi_saf
rm -r prepbufr_nam
rm -r umd
cd ecmwf/
rm ecmwf.2026031612.anl
The above steps replicate how the NameError was first noticed.
Then run qsub jevs_stats_subseasonal_cfs_grid2grid.sh and qsub jevs_stats_subseasonal_gefs_grid2grid.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant