Skip to content

Minor updates and housekeeping#56

Merged
aerorahul merged 4 commits intoNOAA-EMC:production/mlglobal.v1from
aerorahul:feature/update_envyml
Sep 26, 2025
Merged

Minor updates and housekeeping#56
aerorahul merged 4 commits intoNOAA-EMC:production/mlglobal.v1from
aerorahul:feature/update_envyml

Conversation

@aerorahul
Copy link
Contributor

This PR is a minor cleanup and housekeeping. Specifically,

  • updates gitignore to include netcdf and grib2 files so they do not get committed to the repo
  • updates the graphcast submodule pointer to the NOAA-EMC/graphcast instead of google-deepmind. This does not change the virtual envs.
  • updates the environment.yml and pyproject.toml to be consistent.

Copy link
Collaborator

@LinlinCui-NOAA LinlinCui-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

Copy link

@RussellManser-NCO RussellManser-NCO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a question. Is it possible to make sure the graphcast commit hash is consistent between environment.yml and pyproject.toml? I see they are the same here, but I can imagine it's possible they get mismatched in the future.

@aerorahul
Copy link
Contributor Author

Looks good, I just have a question. Is it possible to make sure the graphcast commit hash is consistent between environment.yml and pyproject.toml? I see they are the same here, but I can imagine it's possible they get mismatched in the future.

@RussellManser-NCO
Great question. This has been asked more times than I can remember. environment.yml is used by conda while pyproject.toml is used by pip, pipenv etc.
I have searched for an answer before and recently as well, and have not found a solution that works consistently and is simple enough. The accepted rule here is, deal with it, or drop one or the other, or don't enforce versions. I think dealing with it is more attractive than the alternatives.

@aerorahul aerorahul merged commit 4e24053 into NOAA-EMC:production/mlglobal.v1 Sep 26, 2025
@aerorahul aerorahul deleted the feature/update_envyml branch September 26, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants