RRFSv1 updates: new fields by EricJames-NOAA · Pull Request #1473 · NOAA-EMC/UPP

EricJames-NOAA · 2026-03-20T19:04:41Z

This PR adds several new fields for RRFSv1, based on developer and user requests:

(1) Vertically integrated total dust (COLMD), which is a sum of COLMD for coarse dust and fine dust
(2) Fire radiative power (FRADPOW)
(3) Total dust emissions (AEMFLX)
(4) Aerosol layer top (HGTMD), which is highest height where smoke + total dust exceeds 1 ug/m3
(5) Aerosol layer bottom (HGTMD), which is lowest height where smoke + total dust exceeds 1 ug/m3
(6) Aerosol layer mass-weighted centroid (HGTMD)

The code was tested on Jet for RRFSv1 output.

…threshold concentration

BenjaminBlake-NOAA · 2026-03-23T11:05:24Z

@EricJames-NOAA Thanks for submitting this PR to add these new fields for RRFSv1. I'll review and test your changes today.

@WenMeng-NOAA Let's process this PR next. We would like to get these new fields into the RRFS real-time parallel soon.

sorc/ncep_post.fd/MDLFLD.f

BenjaminBlake-NOAA · 2026-03-23T13:57:46Z

@EricJames-NOAA I tested your changes on Ursa and I see 6 new fields in the 2DFLD GRIB2 file:

COLMD (aerosol=Dust dry:aerosol_size <1e-05) - vertically integrated total dust
FRADPOW
AEMFLX (aerosol=Dust dry:aerosol_size <1e-05) - total dust emissions
HGTMD (highest level > 1e-09) - aerosol layer top height
HGTMD (lowest level > 1e-09) - aerosol layer bottom height
HGTMD (entire atmosphere) - I assume this one is for aerosol layer mass-weighted centroid height

Here is my run directory on Ursa if you could check and make sure the results look good:
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473/rrfs_2025040112
Thanks!

WenMeng-NOAA · 2026-03-23T15:41:27Z

sorc/ncep_post.fd/CALPW.f

      INTEGER LLMH,I,J,L
      REAL ALPM,DZ,PM,PWSUM,RHOAIR,DP,ES
      REAL QDUM(ista:iend,jsta:jend), PWS(ista:iend,jsta:jend),QS(ista:iend,jsta:jend)
+      REAL COLMD(ista:iend,jsta:jend), COLMD2(ista:iend,jsta:jend)


@EricJames-NOAA May I suggest using dynamic arrays (allocatable) for these two new arrays and deallocating them at the end of this subroutine?

EricJames-NOAA · 2026-03-23T15:54:13Z

@EricJames-NOAA I tested your changes on Ursa and I see 6 new fields in the 2DFLD GRIB2 file:

COLMD (aerosol=Dust dry:aerosol_size <1e-05) - vertically integrated total dust

FRADPOW

AEMFLX (aerosol=Dust dry:aerosol_size <1e-05) - total dust emissions

HGTMD (highest level > 1e-09) - aerosol layer top height

HGTMD (lowest level > 1e-09) - aerosol layer bottom height

HGTMD (entire atmosphere) - I assume this one is for aerosol layer mass-weighted centroid height

Here is my run directory on Ursa if you could check and make sure the results look good: /scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473/rrfs_2025040112 Thanks!

@BenjaminBlake-NOAA thanks for the tests. I would like to double check the dust emission field, since the netCDF field was all zero in my earlier test. Can you share the dyn and phy files for your test run? Thanks!

BenjaminBlake-NOAA · 2026-03-23T16:06:30Z

@EricJames-NOAA Sure the dyn/phy files are located here:
/scratch4/NAGAPE/epic/role-epic/ursa/UPP/test_suite/data_in/rrfs

WenMeng-NOAA · 2026-03-23T16:55:26Z

@EricJames-NOAA I tested your changes on Ursa and I see 6 new fields in the 2DFLD GRIB2 file:

COLMD (aerosol=Dust dry:aerosol_size <1e-05) - vertically integrated total dust

FRADPOW

AEMFLX (aerosol=Dust dry:aerosol_size <1e-05) - total dust emissions

HGTMD (highest level > 1e-09) - aerosol layer top height

HGTMD (lowest level > 1e-09) - aerosol layer bottom height

HGTMD (entire atmosphere) - I assume this one is for aerosol layer mass-weighted centroid height

Here is my run directory on Ursa if you could check and make sure the results look good: /scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473/rrfs_2025040112 Thanks!

@BenjaminBlake-NOAA thanks for the tests. I would like to double check the dust emission field, since the netCDF field was all zero in my earlier test. Can you share the dyn and phy files for your test run? Thanks!

@EricJames-NOAA The RRFS model output @BenjaminBlake-NOAA provided are from our UPP RTs. It appears to me a new variables will be read from RRFS model output in this PR. Would you provide us your new sample RRFS output for the RRFS standalone test?

EricJames-NOAA · 2026-03-23T18:49:35Z

@EricJames-NOAA I tested your changes on Ursa and I see 6 new fields in the 2DFLD GRIB2 file:

COLMD (aerosol=Dust dry:aerosol_size <1e-05) - vertically integrated total dust

FRADPOW

AEMFLX (aerosol=Dust dry:aerosol_size <1e-05) - total dust emissions

HGTMD (highest level > 1e-09) - aerosol layer top height

HGTMD (lowest level > 1e-09) - aerosol layer bottom height

HGTMD (entire atmosphere) - I assume this one is for aerosol layer mass-weighted centroid height

Here is my run directory on Ursa if you could check and make sure the results look good: /scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473/rrfs_2025040112 Thanks!

@BenjaminBlake-NOAA thanks for the tests. I would like to double check the dust emission field, since the netCDF field was all zero in my earlier test. Can you share the dyn and phy files for your test run? Thanks!

@EricJames-NOAA The RRFS model output @BenjaminBlake-NOAA provided are from our UPP RTs. It appears to me a new variables will be read from RRFS model output in this PR. Would you provide us your new sample RRFS output for the RRFS standalone test?

@WenMeng-NOAA the new variable read in (emdust) is already available in these files...we just haven't passed it into UPP before.

I checked Ben's test and made one additional changes (correcting units of dust emissions). Based on my tests, the new code appears to be working as intended.

sorc/ncep_post.fd/CALPW.f

Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>

WenMeng-NOAA · 2026-03-23T19:57:08Z

@GangZhao-NOAA @jaymes-kenyon Please note that the correct grib2 name for fire radiative power is implemented in this PR, which impacts on 3DRTMA and MPAS products.

jaymes-kenyon · 2026-03-24T12:42:28Z

This PR looks good! Once merged, I anticipate that several merge conflicts will arise within PR #1455, but I will fix those conflicts.

WenMeng-NOAA · 2026-03-24T12:44:47Z

Thanks for @BenjaminBlake-NOAA conducting the UPP RTs on WCOSS2.
From his testing, I confirm that proposed 6 new fields are output in the rrfs test as:

2DFLD18.tm00:
184:1060698926:d=2025040112:var discipline=2 master_table=2 parmcat=4 parm=36:surface:18 hour fcst:
151:786805359:d=2025040112:COLMD:entire atmosphere (considered as a single layer):18 hour fcst:aerosol=Dust Dry:aerosol_size <1e-05:
185:1062530942:d=2025040112:AEMFLX:entire atmosphere (considered as a single layer):18 hour fcst:aerosol=Dust Dry:aerosol_size <1e-05:
3:15465736:d=2025040112:HGTMD:highest level > 1e-09 kg/m^3:18 hour fcst:
4:18856259:d=2025040112:HGTMD:lowest level > 1e-09 kg/m^3:18 hour fcst:
152:789394348:d=2025040112:HGTMD:entire atmosphere (considered as a single layer):18 hour fcst:

WenMeng-NOAA · 2026-03-24T14:25:47Z

The UPP RTs have been completed on WCOSS2 and all expected changes have been confirmed. There will be baseline updates in the rrfs, mpas, 3drtma, rap, hrrr tests.

BenjaminBlake-NOAA · 2026-03-24T15:33:15Z

@clyden-noaa This PR is ready for testing on the RDHPCs. As @WenMeng-NOAA noted, baseline changes are expected for the rrfs, mpas, mpas_hfip, 3drtma, rap, and hrrr tests. I generated baseline data for you here on Ursa:

/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473-intel
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473-intelllvm

Thanks!

GangZhao-NOAA

The modifications look good to me.

Thanks!

BenjaminBlake-NOAA · 2026-03-25T14:47:27Z

@clyden-noaa We'd like to update the input data for the RRFS baseline test with this PR. The current input files are about a year old. Please hold off on your testing for now and I'll let you know once everything is ready.

BenjaminBlake-NOAA · 2026-03-25T18:03:10Z

@clyden-noaa We can go ahead and proceed with testing.

I have new RRFS input files for you here on Ursa:
/scratch4/NCEPDEV/fv3-cam/Benjamin.Blake/test_suite/data_in/rrfs
These dyn/phy netcdf files should replace the files in EPIC's test_suite directory.

The baseline output data are in the same locations as before:
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473-intel
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-1473-intelllvm

Baseline changes are expected for the rrfs, mpas, mpas_hfip, 3drtma, rap, hrrr, and rrfs_ifi_missing tests. rrfs_ifi_missing is now changed because we updated the RRFS input files.

Once Orion and Hercules are back online I can copy the RRFS input files over to those systems for you. Thanks!

WenMeng-NOAA · 2026-03-25T18:03:48Z

@BenjaminBlake-NOAA Thanks for updates in rrfs test with new data_in baseline and related job cards.
From my UPP RTs on WCOSS2, there are following tests having data_out baseline changes:
3drtma
mpas
rap
hrrr
rrfs
rrfs_missing
rrfs_ifi **We might skip update in this test, as rrfs_ifi will be removed from the UPP RTs

I also confirm that the proposed new rrfs variables are in place.

clyden-noaa

@WenMeng-NOAA @BenjaminBlake-NOAA @EricJames-NOAA
My testing has been completed

There are baseline changes for the following:

mpas
- POSTTWO18.tm00
hrrr
- WRFTWO.GrbF10
mpas_hfip
- 2DFLD.GrbF48
rrfs_ifi_missing
- IFIFIP36.tm00
3drtma
- WRFTWO.GrbF00
rrfs
- NATLEV36.tm00
- 2DFLD36.tm00
- PRSLEV36.tm00
rap
- WRFPRS.GrbF06
- WRFNAT.GrbF06

There were new input files for rrfs:

dynf036.nc
phyf036.nc

All input files were copied to their resepective test suites on all RDHPCs
All baseline files were created and copied to their proper locations on all RDHPCs for both intel (ursa, hercules, orion) and intelllvm (ursa) compilers

Following baseline file creation, all RTs ran successfully and within established timing thresholds on all RDHPC systems.

Ursa - intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
No changes in test results detected.

Ursa - intelllvm

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
No changes in test results detected.

Orion - intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
No changes in test results detected.

Hercules - intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'rrfs_ifi_missing', 'gfs']
No changes in test results detected.

BenjaminBlake-NOAA

@clyden-noaa Thanks for testing and updating the baselines.

@EricJames-NOAA Thanks for adding these new products to RRFS. I will work on getting them added to the real-time parallel soon.

@WenMeng-NOAA Unless you have any final concerns, this PR is ready for merging.

EricJames-NOAA added 7 commits February 27, 2026 23:15

Initial commit for adding RRFSv1 additional products.

78ca8b0

Committing code that works for all the new fields.

65a43fa

Updating change logs.

4939c15

Updates for GRIB2 labeling and using spval when aerosols are below a …

ff98c10

…threshold concentration

Updating more fix files for RRFS.

3dea91b

Merge remote-tracking branch 'origin/develop' into rrfsv1_updates

e29928c

Updating fix files.

e788b10

EricJames-NOAA requested review from BenjaminBlake-NOAA and WenMeng-NOAA as code owners March 20, 2026 19:04

BenjaminBlake-NOAA added RRFS Ready for Review This PR is ready for code review. labels Mar 23, 2026

BenjaminBlake-NOAA linked an issue Mar 23, 2026 that may be closed by this pull request

Add dust, fire radiative power, and aerosol layer height fields to RRFS #1474

Closed

BenjaminBlake-NOAA reviewed Mar 23, 2026

View reviewed changes

sorc/ncep_post.fd/MDLFLD.f Show resolved Hide resolved

BenjaminBlake-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Mar 23, 2026

Adding change log entry for aerosol layer top and bottom

f1506e5

WenMeng-NOAA reviewed Mar 23, 2026

View reviewed changes

Merge branch 'develop' into rrfsv1_updates

7fb70a1

EricJames-NOAA added 3 commits March 23, 2026 18:39

Making COLMD and COLMD2 allocatable in CALPW.

4bf95da

Merge remote-tracking branch 'origin/develop' into rrfsv1_updates

f55c1b1

Merge remote-tracking branch 'ej/rrfsv1_updates' into rrfsv1_updates

f9f2247

WenMeng-NOAA reviewed Mar 23, 2026

View reviewed changes

sorc/ncep_post.fd/CALPW.f Outdated Show resolved Hide resolved

WenMeng-NOAA reviewed Mar 23, 2026

View reviewed changes

sorc/ncep_post.fd/CALPW.f Outdated Show resolved Hide resolved

EricJames-NOAA and others added 2 commits March 23, 2026 12:56

Update sorc/ncep_post.fd/CALPW.f

19dc32e

Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>

Update sorc/ncep_post.fd/CALPW.f

b45f2c5

Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>

WenMeng-NOAA requested review from GangZhao-NOAA and jaymes-kenyon March 23, 2026 19:52

Fix post_avblflds.xml schema error with level=1

b2f110a

WenMeng-NOAA added MPAS 3DRTMA bug Something isn't working labels Mar 24, 2026

WenMeng-NOAA linked an issue Mar 24, 2026 that may be closed by this pull request

Fix the GRIB2 ID for fire radiative power #1475

Closed

jaymes-kenyon approved these changes Mar 24, 2026

View reviewed changes

Add RT log for WCOSS2

4a9de9f

BenjaminBlake-NOAA requested a review from clyden-noaa March 24, 2026 15:30

BenjaminBlake-NOAA added the Ready for commit queue label Mar 24, 2026

GangZhao-NOAA approved these changes Mar 24, 2026

View reviewed changes

Update cycle and forecast hour for RRFS RT

d48384f

clyden-noaa and others added 4 commits March 26, 2026 07:26

Ursa RT log for intel compiler

aa2368e

Ursa RT log for intelllvm compiler

b8d3d5a

Orion RT log for intel compiler

507eefe

Hercules RT log for intel compiler

0f4d8a2

clyden-noaa approved these changes Mar 26, 2026

View reviewed changes

BenjaminBlake-NOAA approved these changes Mar 26, 2026

View reviewed changes

WenMeng-NOAA approved these changes Mar 26, 2026

View reviewed changes

BenjaminBlake-NOAA merged commit ae7666c into NOAA-EMC:develop Mar 26, 2026
4 checks passed

BenjaminBlake-NOAA mentioned this pull request Mar 26, 2026

Updates in develop branch since 06/2025 #1222

Open

Conversation

EricJames-NOAA commented Mar 20, 2026

Uh oh!

BenjaminBlake-NOAA commented Mar 23, 2026

Uh oh!

Uh oh!

BenjaminBlake-NOAA commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WenMeng-NOAA Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

EricJames-NOAA commented Mar 23, 2026

Uh oh!

BenjaminBlake-NOAA commented Mar 23, 2026

Uh oh!

WenMeng-NOAA commented Mar 23, 2026

Uh oh!

EricJames-NOAA commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

WenMeng-NOAA commented Mar 23, 2026

Uh oh!

jaymes-kenyon commented Mar 24, 2026

Uh oh!

WenMeng-NOAA commented Mar 24, 2026

Uh oh!

WenMeng-NOAA commented Mar 24, 2026

Uh oh!

BenjaminBlake-NOAA commented Mar 24, 2026

Uh oh!

GangZhao-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

BenjaminBlake-NOAA commented Mar 25, 2026

Uh oh!

BenjaminBlake-NOAA commented Mar 25, 2026

Uh oh!

WenMeng-NOAA commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clyden-noaa left a comment

Choose a reason for hiding this comment

Uh oh!

BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BenjaminBlake-NOAA commented Mar 23, 2026 •

edited

Loading

WenMeng-NOAA commented Mar 25, 2026 •

edited

Loading