No anlstat job if no JEDI

[DavidNew-NOAA]

Description

This PR turns off the anlstat job if JEDI is not being used. The motivation is that the anlstat job in JEDI-based and will fail if GDSASApp is not built.

There is one niche application where the JEDI-based anlstat job will be used in conjunction with a GSI-based analysis, but that is only used for comparing GSI and JEDI anlayses via the same observation statistics framework (JEDI-based anlstat), and that can be turned on manually when necessary.

Resolves #4450

Type of change

• Bug fix (fixes something broken)
• New feature (adds functionality)
• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
  • GFS
  • GEFS
  • SFS
  • GCAFS
• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO
• Does this change require an update to any of the following submodules? NO
  • EMC verif-global
  • GDAS
  • GFS-utils
  • GSI
  • GSI-monitor
  • GSI-utils
  • UFS-utils
  • UFS-weather-model
  • wxflow

How has this been tested?

Ensure that gdas_anlstat is turned off after initializing C96C48_hybatmDA experiment.

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have documented my code, including function, input, and output descriptions
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test or a new one has been added
• Any new scripts have been added to the .github/CODEOWNERS file with owners
• I have made corresponding changes to the system documentation if necessary

[TravisElless-NOAA]

Just a question/suggestion from me. Would it be cleaner to have a separate if block just for the anlstat flag instead of having this nested if statement (sorry it wouldn't let me suggest it as one big change). There is also a export DO_ANLSTAT="YES" statement around line 90 in the config.base files. Would removing that and just having DO_ANLSTAT defined here be better?

[TravisElless-NOAA]

Suggested change

export DO_ANLSTAT="YES" # JEDI-based analysis statistics

[TravisElless-NOAA]

Suggested change

	else
	fi

[TravisElless-NOAA]

Suggested change

	if [[ ${DO_AERO_ANL} = "YES" || ${DO_JEDIOCNVAR} = "YES" || ${DO_JEDISNOWDA} = "YES" ]]; then
	export DO_ANLSTAT="YES" # JEDI-based analysis statistics
	else
	export DO_ANLSTAT="NO"
	fi
	if [[ "${DO_JEDIATMVAR}" = "YES" || ${DO_AERO_ANL} = "YES" || ${DO_JEDIOCNVAR} = "YES" || ${DO_JEDISNOWDA} = "YES" ]]; then
	export DO_ANLSTAT="YES" # JEDI-based analysis statistics
	else
	export DO_ANLSTAT="NO"

[DavidNew-NOAA]

@TravisElless-NOAA Yes I think that makes sense. I didn't know why these flags are being set first and then changed later, but I can make it simpler. I do think it should be one block, because this block turns off GSI obs monitoring and turns JEDI obs monitoring on, hence the other flags