Update eobs ATMGES variable in JJOB#4663
Open
CatherineThomas-NOAA wants to merge 3 commits intoNOAA-EMC:dev/gfs.v17from
Open
Update eobs ATMGES variable in JJOB#4663CatherineThomas-NOAA wants to merge 3 commits intoNOAA-EMC:dev/gfs.v17from
CatherineThomas-NOAA wants to merge 3 commits intoNOAA-EMC:dev/gfs.v17from
Conversation
CatherineThomas-NOAA
requested review from
JessicaMeixner-NOAA,
RuiyuSun and
lgannoaa
Contributor
Author
|
WCOSS2 -G Tests |
Contributor
Author
|
Gaea C6 -G Tests |
CatherineThomas-NOAA
requested review from
DavidHuber-NOAA and
TravisElless-NOAA
as code owners
DavidHuber-NOAA
approved these changes
Mar 16, 2026
TravisElless-NOAA
approved these changes
Mar 16, 2026
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks @CatherineThomas-NOAA!
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@lgannoaa discovered a silent failure in the v17 real time in the eobs JJOB JGLOBAL_ENKF_SELECT_OBS:
The variable
ATMGESis not defined in this JJOB. This PR replaces this variable withATMGES_ENSMEAN, eliminating the error and properly definingLEVS.This PR brings this fix into the
dev/gfs.v17branch. The fix will be added to thedevelopbranch separately.Refs #4615
Type of change
Change characteristics
How has this been tested?
All generate_workflow -G tests pass on WCOSS2 and Gaea C6 (results will be posted in the comments). v17 low res test results are identical with current
dev/gfs.v17on WCOSS2.Checklist