Turn off anlstat job for GSI based experiments by default#4710
Turn off anlstat job for GSI based experiments by default#4710
Conversation
Co-authored-by: CoryMartin-NOAA <6354668+CoryMartin-NOAA@users.noreply.github.com> Agent-Logs-Url: https://github.com/NOAA-EMC/global-workflow/sessions/e807e5c3-fd50-4155-8fb7-66f5c153d3f9
|
@copilot this isn't quite right, please look at the entire config.base file in that hash, there was logic towards the end that turned it back to YES depending on other settings |
…riments Co-authored-by: CoryMartin-NOAA <6354668+CoryMartin-NOAA@users.noreply.github.com> Agent-Logs-Url: https://github.com/NOAA-EMC/global-workflow/sessions/cefb67f9-77b4-4927-9b2b-8729585fd41b
Fixed in aa11aae. Restored the conditional block from |
|
@CoryMartin-NOAA @DavidNew-NOAA I think this would also resolve #4450 and could supersede #4465. Could we close #4465 in favor of this approach? |
|
Probably. @DavidNew-NOAA thoughts? I somehow missed that this was open |
|
@CoryMartin-NOAA @DavidHuber-NOAA Yes, agree |
|
Launching CI on Hercules. @DavidHuber-NOAA The build on Hercules Slurm timed out building gdas ~T.McG |
|
@copilot please add documentation to |
|
I didn't know I could hijack someone else's copilot session 😮 |
Co-authored-by: DavidHuber-NOAA <69919478+DavidHuber-NOAA@users.noreply.github.com> Agent-Logs-Url: https://github.com/NOAA-EMC/global-workflow/sessions/1ac7a897-c976-4fd8-92e7-09534e512adb
12a8990
Added in 12a8990. The two new entries appear after
|
|
Hercules CI failure here appears to be due to the build job timing out. I'll rekick it and see if it gets going again |
|
@TravisElless-NOAA Yes gdas timed out its build on Hercules. BTW when restarting a build job in GitLab it will start over again because it has to re-clone unlike all the other jobs that pick up where they left off. |
Description
The
anlstatjob was unconditionally running for GSI-based experiments, causing issues on some platforms. This PR turns it off by default for GSI experiments and adds an explicit opt-in flag, while preserving the existing behavior that enablesDO_ANLSTATfor JEDI-based experiments.Changes:
dev/parm/config/gfs/config.base.j2: RevertsDO_ANLSTATdefault back to"NO"(as it was ine8d51af); adds newDO_GSI_ANLSTAT="NO"flag; restores the conditional logic frome8d51afthat turnsDO_ANLSTATback to"YES"for JEDI-based experiments:DO_JEDIATMVAR="YES"(JEDI atmospheric variational DA)DO_AERO="YES",DO_JEDIOCNVAR="YES", orDO_JEDISNOWDA="YES"dev/scripts/exglobal_analysis_stats.py: Replaces the unconditionalelse: append('atmos_gsi')withelif config.DO_GSI_ANLSTAT:— GSI analysis stats now only run when explicitly opted indocs/source/configure.rst: Added documentation forDO_ANLSTATandDO_GSI_ANLSTAToptionsTo re-enable GSI analysis statistics, set
DO_GSI_ANLSTAT="YES"in the experiment configuration. JEDI-based experiments are unaffected —DO_ANLSTATis still automatically enabled for them via the conditional logic inconfig.base.j2.Type of change
Change characteristics
anlstatrunning by default will no longer run it unlessDO_GSI_ANLSTAT="YES"is setDO_ANLSTATandDO_GSI_ANLSTAThas been added todocs/source/configure.rstHow has this been tested?
Code review only; no runtime tests conducted.
Checklist
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.