Added optional flag to time_interp_external to speedup initialization#1427
Open
MJHarrison-GFDL wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
Added optional flag to time_interp_external to speedup initialization#1427MJHarrison-GFDL wants to merge 1 commit intoNOAA-GFDL:mainfrom
MJHarrison-GFDL wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
- time_interp_external_nml:check_uniform_times=.true. will enable this option which performs a time axis check for uniformly spaced time levels prior to attempting to read the entire axis. In some cases, this will significantly reduce initialization time when reading large input files via data_override for example.
Member
|
@MJHarrison-GFDL Thank you for the PR. Can you include a test that tests the functionality so we can include it in our test suite. Also, can you opne an issue describing the problem you are trying to solve. |
Contributor
Author
|
@thomas-robinson . The test I used is located on gaea : /lustre/f2/dev/Matthew.Harrison/tmp/FMS_fast_data_override/test . Initialization time went from 5min -> 2sec. |
Member
|
@MJHarrison-GFDL that's great! Do you need help getting this test into the FMS test suite? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
time_interp_external_nml:check_uniform_times=.true. will enable this option which performs a time axis check for uniformly spaced time levels prior to attempting to read the entire axis. In some cases, this will significantly reduce initialization time when reading large input files via data_override for example. It is possible that enabling this option
will result in answer changes in some configurations, so it is currently being set False by defauly.
Fixes # (issue)
How Has This Been Tested?
Using a stand-alone driver. Tested for single threading only.
Checklist:
make distcheckpasses