Remove cray pointers from exchange/xgrid.f90#1778
Merged
vithikashah001 merged 2 commits intoNOAA-GFDL:mainfrom Nov 20, 2025
Merged
Remove cray pointers from exchange/xgrid.f90#1778vithikashah001 merged 2 commits intoNOAA-GFDL:mainfrom
exchange/xgrid.f90#1778vithikashah001 merged 2 commits intoNOAA-GFDL:mainfrom
Conversation
foxtran
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
foxtran
changed the title
exchange/xgrid.f90
rem1776
approved these changes
Nov 20, 2025
uramirez8707
approved these changes
Nov 20, 2025
Contributor
uramirez8707
left a comment
uramirez8707
left a comment
There was a problem hiding this comment.
Thanks for the update @foxtran. Looks good to me.
vithikashah001
approved these changes
Nov 20, 2025
Contributor
Author
|
Looks like somehow this PR broke xgrid test with autotools... But I do not see where; stacktraces are also not helpful. |
8 tasks
Contributor
Author
|
Fix is available in #1795. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've replaced all cray pointers in
exchange/xgrid.f90to Fortran pointers that is possible with Fortran 2008 features. Actually, Fortran 2008 compiler is required for compiling FMS, so, there is no problem to use a bit more Fortran 2008 features.Related to #54
How Has This Been Tested?
I have raised compiler errors by excluding
-fcray-pointerflag during compilation of module. Then, in semi-automatic manner, I fixed all of them. No actual tests were running (I will let CI do it).Checklist:
make distcheckpasses