Skip to content

DIAG MANAGER: Fixes to zbounds#1880

Merged
vithikashah001 merged 2 commits into
NOAA-GFDL:mainfrom
uramirez8707:dm_zregions
Jun 1, 2026
Merged

DIAG MANAGER: Fixes to zbounds#1880
vithikashah001 merged 2 commits into
NOAA-GFDL:mainfrom
uramirez8707:dm_zregions

Conversation

@uramirez8707
Copy link
Copy Markdown
Contributor

Description
Fixes #1879

  1. Corrects the setting up starting/ending indices for sub axis to support decreasing/increasing arrays
  2. Adds a select type before writing the data to correctly send subaxis data
  3. Improves test by adding a test with a decreasing zaxis + adds checks to ensure the data was written correctly

How Has This Been Tested?
CI + Test case from Fabien

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

…t decreasing/increasing arrays + make tests more robust + adds a select type before writing the data to correctly send subaxis data
@vithikashah001 vithikashah001 merged commit cda48c8 into NOAA-GFDL:main Jun 1, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MODERN_DIAG_MANAGER: zbounds fail when the zaxis data is monotonically decreasing

3 participants