Skip to content

Feature/ETC_composites#153

Open
jeyavinoth wants to merge 135 commits intoNOAA-GFDL:mainfrom
jeyavinoth:feature/ETC-composites
Open

Feature/ETC_composites#153
jeyavinoth wants to merge 135 commits intoNOAA-GFDL:mainfrom
jeyavinoth:feature/ETC-composites

Conversation

@jeyavinoth
Copy link
Copy Markdown
Contributor

This is a preliminary version of the POD that tracks extra tropical cyclones and computes cyclone centered composites.

Summary:
The Extratropical cyclones are identified with the Modeling, Analysis and Prediction (MAP) Climatology of Midlatitude Storminess (MCMS) algorithm (Bauer et al. 2016) which uses 6-hourly gridded sea level pressure fields to locate storm centers and then track them through the cyclone lifetime. This algorithm has historically been used to create a database of cyclone locations using the ERA-Interim reanalysis (Dee et al. 2011). The MCMS algorithm is also applied to the model and re-analysis sea level pressure fields. We generate cyclone centered composites of cloud cover, as well as other atmospheric variables, over multiple instances of the same type of atmospheric phenomenon to compare the models with observations or reanalysis. The is a plan view as a passive instrument would observe. This method presents a great advantage for model evaluation as they allow multiple cases to be included and do not necessitate a match in time and space between the free running models and observations.

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Dec 18, 2021

This pull request introduces 628 alerts when merging b41168c into 858303d - view on LGTM.com

new alerts:

  • 229 for Unused local variable
  • 121 for Unused import
  • 84 for Variable defined multiple times
  • 66 for Except block handles 'BaseException'
  • 54 for Unreachable code
  • 40 for Testing equality to None
  • 5 for Module is imported more than once
  • 5 for Suspicious unused loop iteration variable
  • 4 for Non-iterable used in for loop
  • 3 for Non-callable called
  • 3 for Syntax error
  • 3 for Nested loops with same variable
  • 2 for Redundant comparison
  • 2 for Wrong number of arguments for format
  • 2 for Wrong number of arguments in a call
  • 1 for Signature mismatch in overriding method
  • 1 for Unnecessary pass
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Import of deprecated module
  • 1 for Modification of parameter with default

jeyavinoth and others added 8 commits March 1, 2022 05:46
Add atmos variables to the diag table
Note that this currently generates variables required for the MJO_suite POD using GFDL standard output
more variables may be required for the other PODs. It is also preferable to output in CMIP6 format
@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Mar 16, 2022

This pull request introduces 628 alerts when merging 5cbaaf3 into 748d6da - view on LGTM.com

new alerts:

  • 229 for Unused local variable
  • 121 for Unused import
  • 84 for Variable defined multiple times
  • 66 for Except block handles 'BaseException'
  • 54 for Unreachable code
  • 40 for Testing equality to None
  • 5 for Module is imported more than once
  • 5 for Suspicious unused loop iteration variable
  • 4 for Non-iterable used in for loop
  • 3 for Non-callable called
  • 3 for Syntax error
  • 3 for Nested loops with same variable
  • 2 for Redundant comparison
  • 2 for Wrong number of arguments for format
  • 2 for Wrong number of arguments in a call
  • 1 for Signature mismatch in overriding method
  • 1 for Unnecessary pass
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Import of deprecated module
  • 1 for Modification of parameter with default

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Mar 16, 2022

This pull request introduces 132 alerts when merging 5718729 into 748d6da - view on LGTM.com

new alerts:

  • 57 for Unused local variable
  • 23 for Unreachable code
  • 18 for Variable defined multiple times
  • 14 for Unused import
  • 11 for Except block handles 'BaseException'
  • 3 for Module is imported more than once
  • 2 for Nested loops with same variable
  • 1 for Signature mismatch in overriding method
  • 1 for Redundant comparison
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Wrong number of arguments for format

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Mar 16, 2022

This pull request introduces 107 alerts when merging 8697263 into 748d6da - view on LGTM.com

new alerts:

  • 48 for Unused local variable
  • 21 for Unreachable code
  • 11 for Except block handles 'BaseException'
  • 11 for Variable defined multiple times
  • 7 for Unused import
  • 3 for Module is imported more than once
  • 2 for Nested loops with same variable
  • 1 for Signature mismatch in overriding method
  • 1 for Redundant comparison
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Wrong number of arguments for format

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Mar 20, 2022

This pull request introduces 85 alerts when merging 6d5460c into 748d6da - view on LGTM.com

new alerts:

  • 39 for Unused local variable
  • 20 for Unreachable code
  • 11 for Except block handles 'BaseException'
  • 3 for Module is imported more than once
  • 3 for Unused import
  • 3 for Variable defined multiple times
  • 2 for Nested loops with same variable
  • 1 for Signature mismatch in overriding method
  • 1 for Redundant comparison
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Wrong number of arguments for format

@lgtm-com
Copy link
Copy Markdown
Contributor

lgtm-com bot commented Mar 30, 2022

This pull request introduces 74 alerts when merging 7f9732c into 748d6da - view on LGTM.com

new alerts:

  • 33 for Unused local variable
  • 20 for Unreachable code
  • 6 for Variable defined multiple times
  • 5 for Except block handles 'BaseException'
  • 3 for Unused import
  • 2 for Nested loops with same variable
  • 1 for Signature mismatch in overriding method
  • 1 for Redundant comparison
  • 1 for Module is imported more than once
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Wrong number of arguments for format

@wrongkindofdoctor wrongkindofdoctor changed the base branch from develop to main June 17, 2022 14:26
@ahmedfiaz
Copy link
Copy Markdown
Collaborator

Hi @jeyavinoth, checking if you are still able to contribute to this PR? It looks like your code had some outstanding issues that must be addressed before it can be merged.

@jeyavinoth
Copy link
Copy Markdown
Contributor Author

Hi @jeyavinoth, checking if you are still able to contribute to this PR? It looks like your code had some outstanding issues that must be addressed before it can be merged.

@ahmedfiaz I haven't worked on this in a long while. Please follow up with @jfbooth (Jimmy Booth from CCNY)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostic Issue pertains to a contributed diagnostic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add variables to fieldlist_GFDL.jsonc to support ETC_composites POD

8 participants