Skip to content

Feature/pac_wwes#796

Open
erileydellaripa wants to merge 4 commits intoNOAA-GFDL:mainfrom
erileydellaripa:feature/Pac_WWEs
Open

Feature/pac_wwes#796
erileydellaripa wants to merge 4 commits intoNOAA-GFDL:mainfrom
erileydellaripa:feature/Pac_WWEs

Conversation

@erileydellaripa
Copy link
Copy Markdown

Description
This POD identifies WWEs and their characteristics across the Pacific Ocean (120E-280E) using daily equatorially averaged (2.5S - 2.5N) 120-day highpass filtered zonal wind stress from TropFlux observation and earth system models (ESMs).

After merging the latest updates from NOAA-GFDL main, my POD runs significantly slower, see issue #795 below. Besides the POD running slower than before, it is a completed POD ready for evaluation to be integrated into the package.

Associated issue #795

How Has This Been Tested?
Python: 3.12.10
OS: MAC OS 10.15.7
Conda version: 23.5.2
POD wall clock time - about an hour. It was 10 minutes before when running 3.12.9 in February.

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

Remove last two lines of WWE.rst file as they are not needed

Add sftl to fieldlist_CMIP.jsonc

Replace Test WWE POD name with just WWE POD

Update WWE csv and json files

Comment out pip modules in yml files

Removed extra s in title of html file

Update description of WWE POD functionality in rst file

Move realm description to each variable instead of on its own under data

Set save_pp_data to True so that files wouldn't be deleted

Change pattern of file name to look for in test_builder_config.yml

CESM2 historical json file

Add INM-CM4-8 csv and json files
@aradhakrishnanGFDL aradhakrishnanGFDL added the diagnostic Issue pertains to a contributed diagnostic label May 14, 2025
@@ -0,0 +1,506 @@
import numpy as np
import xarray as xr
import os

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'os' is not used.
import matplotlib
matplotlib.use("Agg") # non-X windows backend

import matplotlib.pyplot as plt

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'plt' is not used.
import time
import xesmf as xe
import scipy
from scipy import stats

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'xe' is not used.
import xesmf as xe
import scipy
from scipy import stats
from functools import partial

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'scipy' is not used.
import scipy
from scipy import stats
from functools import partial
import intake

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'stats' is not used.
@aradhakrishnanGFDL
Copy link
Copy Markdown
Collaborator

@aradhakrishnanGFDL re-run workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostic Issue pertains to a contributed diagnostic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants