Skip to content

Fixes shelfwave failure in debug mode #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev/gfdl
Choose a base branch
from
Open

Fixes shelfwave failure in debug mode #980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
431506d
Fixes shelfwave failure in debug mode
kshedstrom Oct 10, 2025
5f7dc80
Make sure reversed segments get rotated.
kshedstrom Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/core/MOM_open_boundary.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6444,6 +6444,7 @@ subroutine rotate_OBC_config(OBC_in, G_in, OBC, G, turns)
OBC%zero_biharmonic = OBC_in%zero_biharmonic
OBC%silly_h = OBC_in%silly_h
OBC%silly_u = OBC_in%silly_u
OBC%reverse_segment_order = OBC_in%reverse_segment_order

! Segment rotation
allocate(OBC%segment(0:OBC%number_of_segments))
Expand Down Expand Up @@ -6671,6 +6672,11 @@ subroutine rotate_OBC_segment_config(segment_in, G_in, segment, G, turns)
! These are conditionally set if Lscale_{in,out} are present
segment%Tr_InvLscale_in = segment_in%Tr_InvLscale_in
segment%Tr_InvLscale_out = segment_in%Tr_InvLscale_out
segment%Th_InvLscale_in = segment_in%Th_InvLscale_in
segment%Th_InvLscale_out = segment_in%Th_InvLscale_out

! This needs to be set
segment%num_fields = segment_in%num_fields
end subroutine rotate_OBC_segment_config


Expand Down Expand Up @@ -6982,6 +6988,10 @@ subroutine write_OBC_info(OBC, G, GV, US)
call MOM_mesg(mesg, verb=1)
write(mesg, '(" Tr_InvLscale_in ", ES16.6)') segment%Tr_InvLscale_in*US%m_to_L
call MOM_mesg(mesg, verb=1)
write(mesg, '(" Th_InvLscale_out ", ES16.6)') segment%Th_InvLscale_out*US%m_to_L
call MOM_mesg(mesg, verb=1)
write(mesg, '(" Th_InvLscale_in ", ES16.6)') segment%Th_InvLscale_in*US%m_to_L
call MOM_mesg(mesg, verb=1)

enddo

Expand Down