Skip to content

725.repo dispatch#746

Closed
Ciheim wants to merge 8 commits intomainfrom
725.RepoDispatch
Closed

725.repo dispatch#746
Ciheim wants to merge 8 commits intomainfrom
725.RepoDispatch

Conversation

@Ciheim
Copy link
Copy Markdown
Contributor

@Ciheim Ciheim commented Feb 19, 2026

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.08%. Comparing base (ad432b1) to head (ade82be).
⚠️ Report is 153 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files          70       70           
  Lines        4775     4775           
=======================================
  Hits         4015     4015           
  Misses        760      760           
Flag Coverage Δ
unittests 84.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad432b1...ade82be. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhd789 singhd789 self-requested a review February 20, 2026 15:01
@Ciheim Ciheim marked this pull request as ready for review February 25, 2026 14:49
id: app-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.PPP_REBUILD_APP_ID }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, I'd say either rename PPP here to fre or fre-cli OR add that adjustment to the to-do and link it in this issue: NOAA-GFDL/HPC-ME#22

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit or required?

@ilaflott
Copy link
Copy Markdown
Member

this has been static for a bit- seems good?

@singhd789
Copy link
Copy Markdown
Contributor

this has been static for a bit- seems good?

I think this is going to be refactored by @Ciheim once files are moved over (#785)

@Ciheim
Copy link
Copy Markdown
Contributor Author

Ciheim commented Mar 24, 2026

@ilaflott @singhd789 I think we're good to close this. No longer necessary!

@Ciheim Ciheim closed this Mar 24, 2026
@ilaflott ilaflott deleted the 725.RepoDispatch branch March 25, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants