fre.cmor: replace nccmp subprocess calls with netCDF4 in cmor run subtool tests#826
Open
fre.cmor: replace nccmp subprocess calls with netCDF4 in cmor run subtool tests#826
fre.cmor: replace nccmp subprocess calls with netCDF4 in cmor run subtool tests#826Conversation
Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/3f296191-8cf1-4391-b69c-a844460e0681 Co-authored-by: ilaflott <[email protected]>
Copilot
AI
changed the title
[WIP] Remove and replace
replace Apr 1, 2026
nccmp from test_cmor_run_subtool.pynccmp subprocess calls with netCDF4 in cmor run subtool tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 84.12% 84.12%
=======================================
Files 71 71
Lines 4944 4944
=======================================
Hits 4159 4159
Misses 785 785
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ecks Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/b75a9df0-9832-414c-89bd-10bc365552bf Co-authored-by: ilaflott <[email protected]>
…sing netCDF4+numpy Agent-Logs-Url: https://github.com/NOAA-GFDL/fre-cli/sessions/b75a9df0-9832-414c-89bd-10bc365552bf Co-authored-by: ilaflott <[email protected]>
ilaflott
approved these changes
Apr 1, 2026
Member
ilaflott
left a comment
ilaflott
left a comment
There was a problem hiding this comment.
Wish i did this a long time ago!
ilaflott
changed the title
nccmp subprocess calls with netCDF4 in cmor run subtool testsfre.cmor: replace nccmp subprocess calls with netCDF4 in cmor run subtool tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import numpy as npandCMIP6_REQUIRED_GLOBAL_ATTRSconstant_assert_data_matches()and_assert_metadata_matches()helperstest_fre_cmor_run_subtool_case1_output_compare_data: file format differs + sos data, lat/lon/time coordinates, and shapes preservedtest_fre_cmor_run_subtool_case1_output_compare_metadata: global attrs differ + CMIP6-required attrs present + standard_name/long_name/_FillValue/missing_value preservedtest_fre_cmor_run_subtool_case2_output_compare_data: same data assertions as case1test_fre_cmor_run_subtool_case2_output_compare_metadata: same metadata assertions as case1