Skip to content

Add pytest and pylint to environment dependencies#215

Closed
ilaflott wants to merge 1 commit intoNOAA-GFDL:mainfrom
ilaflott:patch-1
Closed

Add pytest and pylint to environment dependencies#215
ilaflott wants to merge 1 commit intoNOAA-GFDL:mainfrom
ilaflott:patch-1

Conversation

@ilaflott
Copy link
Copy Markdown
Member

also try removing the setuptools bit from environment.yaml

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Manual Pipeline Run Details

Was the manual pipeline (test_cloud_runner) triggered for this PR?

  • Yes
  • No

Result of manual pipeline run:

(Paste relevant logs, output, or a link to the workflow run here)

How to trigger the manual pipeline:

The test_cloud_runner pipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.

To trigger the manual pipeline:

  1. Follow the link to the test_cloud_runner actions tab here

    • you should see "This workflow has a workflow_dispatch event trigger"
  2. Click the dropdown "Run workflow":

    a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test

    b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test

  3. Click "Run workflow"

Note: you may need to reload the page to see your running workflow.

also try removing the setuptools bit
@ilaflott ilaflott marked this pull request as ready for review March 19, 2026 13:16
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added this to #210 during testing, surprised it's not already in.

I didn't remove setuptools though. isn't that needed?

@ilaflott ilaflott marked this pull request as draft March 19, 2026 16:19
@ilaflott
Copy link
Copy Markdown
Member Author

not ready for merge, wondering where the pipeline run is... i took this out of draft to check if that would trigger a run.

Yes. I added this to #210 during testing,

ah i'm not the only one!

surprised it's not already in.

it used to be under fre-cli's environment.yaml, but since it's not required for users, we took it out and stuck it under pyproject.toml. so now if pip installing fre-cli and one wants pylint and pytest, one does pip install .[test] to get those requirements.

I didn't remove setuptools though. isn't that needed?

it was when the container for PPP wasn't updated yet, post fre-cli packaging changes from this PR

@ilaflott ilaflott closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants