[WIP] Fix ocean-ice crash with nvhpc/23.7#5
Open
nikizadehgfdl wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
[WIP] Fix ocean-ice crash with nvhpc/23.7#5nikizadehgfdl wants to merge 1 commit intoNOAA-GFDL:mainfrom
nikizadehgfdl wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
Contributor
nikizadehgfdl
commented
Oct 17, 2023
nikizadehgfdl
commented
- ocean-ice model crashes without any hints somewhere else in land_null. Adding print statements indicate the crash happens in the calls to get_grid_cell_area .
- The ocean-ice models can be run without these calls and by just setting frac=1.0 instead.
- Does not change answers.
- Why is the block of code needed?
- ocean-ice model crashes without any hints somewhere else in land_null. Adding print statements indicate the crash happens in the calls to get_grid_cell_area . - The ocean-ice models can be run without these calls and by just setting frac=1.0 instead. - Does not change answers. - Why is the block of code needed?
Member
|
@rem1776 Does the aquaplanet need this update too? |
Yeah probably, aquaplanet (and doubly_periodic) are compiling land_null with the maco set for LAND_GRID_FROM_ATMOS too. I can try running with these changes once they are done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.