Set minimum value for rough_mom and rough_heat to prevent NaN/Inf #8
Open
Biao-Zhao wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
Set minimum value for rough_mom and rough_heat to prevent NaN/Inf #8Biao-Zhao wants to merge 1 commit intoNOAA-GFDL:mainfrom
Biao-Zhao wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
Contributor
|
This will also fix issue #9 that I just ran into. @Biao-Zhao why did you choose 1.0e-6? lm4 initializes these to 0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rough_momorrough_heatis zero on the exchange grid, calculations of variables such as the friction velocity (ex_u_star) can result in NaN or Inf. This happens because the calculation ofex_u_starinvolve divisions byrough_mom, e.g. logarithmic form ofzref/rough_mom. Setting a minimum value forrough_momandrough_heatprevents these numerical errors and model crash when outputex_u_star.