Changing submodule names to reflect new repository names#179
Changing submodule names to reflect new repository names#179oelbert merged 9 commits intoNOAA-GFDL:developfrom
Conversation
…g to latest versions
jjuyeonkim
left a comment
jjuyeonkim
left a comment
There was a problem hiding this comment.
Besides the pyFV3 linting, it looks okay to me.
pace/registry.py
Outdated
| return register_func | ||
|
|
||
| def from_dict(self, config: dict, hooks={}) -> T: | ||
| def from_dict(self, config: dict, hooks=None) -> T: |
There was a problem hiding this comment.
I don't have a strong opinion blocking this, but should we add type hints? In this example, "config" has a type hint, but "hooks" doesn't have it. Also, the return type is the generic "T". However, the from_dict in pace/initialization.py has a from_dict that doesn't specify a return type hint. If we add a hook type hint, I think it might be dict[type, Callable[[Any], Any]] based on https://github.com/konradhalas/dacite/blob/master/dacite/config.py.
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
One small question about typehints, otherwise fine
|
|
||
| @classmethod | ||
| def from_dict(cls, config: dict, hooks={}): | ||
| def from_dict(cls, config: dict, hooks: dict | None = None): |
There was a problem hiding this comment.
Do you need to add the None typehint to hooks?
| return register_func | ||
|
|
||
| def from_dict(self, config: dict, hooks={}) -> T: | ||
| def from_dict(self, config: dict, hooks: dict | None = None) -> T: |
3 participants
Description
This PR changes the
.gitmodulesfile to match the new names for thepyFV3andpySHiELDsubmodules. Previously the container build test was failing due to the conflict in names.How Has This Been Tested?
Tested using currently implemented workflows.
Checklist: