Skip to content

tests: minor cleanup in tests#181

Merged
oelbert merged 2 commits intoNOAA-GFDL:developfrom
romanc:romanc/tests-cleanup
Mar 10, 2026
Merged

tests: minor cleanup in tests#181
oelbert merged 2 commits intoNOAA-GFDL:developfrom
romanc:romanc/tests-cleanup

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Mar 3, 2026

Description

Minor cleanup in pace tests:

  • add __init__.py files where missing
  • List -> list and Tuple -> tuple
  • NDSL has no Namelist anymore
  • cleanup unused import and code in test_init_from_geos.py

How Has This Been Tested?

All good as long as existing tests are still passing.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc romanc requested review from fmalatino and jjuyeonkim March 3, 2026 09:00
- add `__init__.py` files where missing
- `List` -> `list` and `Tuple` -> `tuple`
- NDSL has no `Namelist` anymore
- cleanup unused import and code in `test_init_from_geos.py`
@romanc romanc force-pushed the romanc/tests-cleanup branch from ef9b43e to c1c266e Compare March 5, 2026 17:55
@romanc
Copy link
Collaborator Author

romanc commented Mar 5, 2026

Rebased onto develop after conflicts popped up. Found a stale reference to ndsl.Namelist, which were removed with NOAA-GFDL/NDSL#297.

@romanc
Copy link
Collaborator Author

romanc commented Mar 9, 2026

@fmalatino what is the status of this PR? It seems like nobody is unhappy with it. Can we merge? (I don't have merge rights in this repo).

@oelbert oelbert added this pull request to the merge queue Mar 10, 2026
Merged via the queue into NOAA-GFDL:develop with commit 562c394 Mar 10, 2026
2 checks passed
@romanc romanc deleted the romanc/tests-cleanup branch March 11, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants