Skip to content

Changing build backend to scikit-build-core#39

Open
fmalatino wants to merge 29 commits intoNOAA-GFDL:mainfrom
fmalatino:fix/build_system
Open

Changing build backend to scikit-build-core#39
fmalatino wants to merge 29 commits intoNOAA-GFDL:mainfrom
fmalatino:fix/build_system

Conversation

@fmalatino
Copy link
Copy Markdown
Contributor

@fmalatino fmalatino commented Mar 18, 2026

Description
This PR introduces changes to the build system to generate an installation of cFMS by way of CMake. As a result, cFMS no longer needs to be a submodule to this repository, as all necessary files will be obtained during the call of FetchContent within the CMakeLists.txt that performs the installation of cFMS alongside pyFMS, using the version of cFMS specified by the tag provided in the file. The shared object file that results from the cFMS installation will now exist alongside the other dependencies within the site-packages of the environment used for installation. It can be discovered through Python built-in functions to provide it for loading.

Fixes # 37
This PR address concerns raised in Issue 37.

How Has This Been Tested?
Unit testing has been performed on all systems available at GFDL and through the implemented workflows.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino requested review from mlee03 and rem1776 March 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant