Changing build backend to scikit-build-core#39
Open
fmalatino wants to merge 29 commits intoNOAA-GFDL:mainfrom
Open
Changing build backend to scikit-build-core#39fmalatino wants to merge 29 commits intoNOAA-GFDL:mainfrom
scikit-build-core#39fmalatino wants to merge 29 commits intoNOAA-GFDL:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to the build system to generate an installation of
cFMSby way of CMake. As a result,cFMSno longer needs to be a submodule to this repository, as all necessary files will be obtained during the call ofFetchContentwithin theCMakeLists.txtthat performs the installation ofcFMSalongsidepyFMS, using the version ofcFMSspecified by the tag provided in the file. The shared object file that results from thecFMSinstallation will now exist alongside the other dependencies within thesite-packagesof the environment used for installation. It can be discovered through Python built-in functions to provide it for loading.Fixes # 37
This PR address concerns raised in Issue 37.
How Has This Been Tested?
Unit testing has been performed on all systems available at GFDL and through the implemented workflows.
Checklist: